Move datatypes definitions in specific modules inside rustc::{traits, infer} #68461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Actually, I have less of a sense of direction wrt. traits/infer, so I'll r? @nikomatsakis :) |
matthewjasper
approved these changes
Feb 2, 2020
|
☔ The latest upstream changes (presumably #68831) made this pull request unmergeable. Please resolve the merge conflicts. |
cjgillot
force-pushed
the
split_infer_prelude
branch
from
7a2702d
to
735d664
Compare
|
r? @matthewjasper |
|
📌 Commit 735d664 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 5, 2020
Move datatypes definitions in specific modules inside rustc::{traits, infer}
Prelude to #67953
Some data types inside `rustc::traits` and `rustc::infer` are used in other parts of `librustc`. These cannot go to a separate crate `librustc_infer`.
This PR moves those data types to `traits::types` and `infer::types` modules, from where everything is reexported.
Note for review: some imports feature the `crate -> rustc` substitution. This is cruft from the splitting out of #67953. This can be reverted, but are bound to be put back by #67953.
r? @Centril
cc @Zoxc
|
☀️ Test successful - checks-azure |
|
This PR made some fields |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prelude to #67953
Some data types inside
rustc::traitsandrustc::inferare used in other parts oflibrustc. These cannot go to a separate cratelibrustc_infer.This PR moves those data types to
traits::typesandinfer::typesmodules, from where everything is reexported.Note for review: some imports feature the
crate -> rustcsubstitution. This is cruft from the splitting out of #67953. This can be reverted, but are bound to be put back by #67953.r? @Centril
cc @Zoxc