Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test for #60976 #68485

Merged
merged 1 commit into from
Jan 26, 2020
Merged

add a test for #60976 #68485

merged 1 commit into from
Jan 26, 2020

Conversation

kingslef
Copy link
Contributor

The test fails on 1.36.0 but passes on master.

Huge thanks for @hellow554 actually digging out the minimized version of the
repro.

Fixes #60976.

The test fails on 1.36.0 but passes on master.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2020
@kingslef
Copy link
Contributor Author

So, passes nicely with master:

$ ./x.py test --stage 1 src/test/ui --test-args extern-use-primitive-type
...
running 1 test
.
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 9546 filtered out

        finished in 8.265
Build completed successfully in 0:00:13

and fails as expected on 1.36.0

$ ./x.py test --stage 1 src/test/ui --test-args extern-use-primitive-type
...
running 1 test
F
failures:

---- [ui] ui/use/issue-60976-extern-use-primitive-type.rs stdout ----

error: Error: expected failure status (Some(1)) but received status Some(101).
status: exit code: 101
command: "/projects/rust-1.36/build/x86_64-apple-darwin/stage1/bin/rustc" "/projects/rust-1.36/src/test/ui/use/issue-60976-extern-use-primitive-type.rs" "-Zthreads=1" "--target=x86_64-apple-darwin" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--o
ut-dir" "/projects/rust-1.36/build/x86_64-apple-darwin/test/ui/use/issue-60976-extern-use-primitive-type" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/projects/rust-1.36/build/x86_64-apple-darwin/native/rust-test-helpers" "-L" "/projects/rust-1.36/build/x86_64-apple-darwin/test/ui/use/issue-60976-extern-use-primitive-type/auxiliary" "-A" "unused"
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
error: internal compiler error: src/librustc/hir/def.rs:340: attempted .def_id() on invalid res: PrimTy(Uint(u32))

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
error: aborting due to previous error


note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.36.0-dev running on x86_64-apple-darwin

note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath


------------------------------------------



failures:
    [ui] ui/use/issue-60976-extern-use-primitive-type.rs

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 5575 filtered out

thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:512:22
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.


command did not execute successfully: "/projects/rust-1.36/build/x86_64-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/projects/rust-1.36/build/x86_64-apple-darwin/stage1/lib" "--run-lib-path" "/projects/rust-1.36/build/x86_64-apple-darwin/stage1/lib/rustlib/x86_64-apple-darwin/lib" "--rustc-path" "/projects/rust-1.36/build/x86_64-apple-darwin/stage1/bin/rustc" "--src-base" "/projects/rust-1.36/src/test/ui" "--build-base" "/projects/rust-1.36/build/x86_64-apple-darwin/test/ui" "--stage-id" "stage1-x86_64-apple-darwin" "--mode" "ui" "--target" "x86_64-apple-darwin" "--host" "x86_64-apple-darwin" "--llvm-filecheck" "/projects/rust-1.36/build/x86_64-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/projects/rust-1.36/build/x86_64-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/projects/rust-1.36/build/x86_64-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--gdb" "/usr/local/bin/gdb" "--lldb-version" "lldb-1100.0.30.6\nApple Swift version 5.1.2 (swiftlang-1100.0.278 clang-1100.0.33.9)\n" "--lldb-python-dir" "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python3" "extern-use-primitive-type" "--quiet" "--llvm-version" "8.0.0-rust-1.36.0-dev-2c5656ae5\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" ""
expected success, got: exit code: 101


failed to run: /projects/rust-1.36/build/bootstrap/debug/bootstrap test --stage 1 src/test/ui --test-args extern-use-primitive-type
Build completed unsuccessfully in 0:00:23

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

Great!

@bors
Copy link
Contributor

bors commented Jan 24, 2020

📌 Commit ad1cdec has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 25, 2020
…akis

add a test for rust-lang#60976

The test fails on 1.36.0 but passes on master.

Huge thanks for @hellow554 actually digging out the minimized version of the
repro.

Fixes rust-lang#60976.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 25, 2020
…akis

add a test for rust-lang#60976

The test fails on 1.36.0 but passes on master.

Huge thanks for @hellow554 actually digging out the minimized version of the
repro.

Fixes rust-lang#60976.
bors added a commit that referenced this pull request Jan 25, 2020
Rollup of 5 pull requests

Successful merges:

 - #68485 (add a test for #60976)
 - #68498 (Add some type-alias-impl-trait regression tests)
 - #68514 (Use Self instead of self return type)
 - #68534 (Update submodules to rust-lang)
 - #68540 (clean up error codes E0229 and E0261)

Failed merges:

r? @ghost
@bors bors merged commit ad1cdec into rust-lang:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler panics after restructuring of project: attempted .def_id() on invalid def: PrimTy(Float(f64))
4 participants