Document ThreadSanitizer in unstable-book #70268
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Just curious: Why don't you add committer email address to your github account? |
| `x86_64-unknown-linux-gnu` target. | ||
|
|
||
| MemorySanitizer requires all program code to be instrumented. Failing to achieve | ||
| that will result in false positive reports. |
There was a problem hiding this comment.
This means "if you link to C code it needs to be compiled with memorysantizer too", right?
There was a problem hiding this comment.
Yes, expanded on this a bit to give more context to the example that follows.
In general this is a major challenge when using MemorySanitizer in larger code
bases. For those written mostly in Rust and using Cargo, it works surprisingly
well.
|
@bors: r+ rollup |
|
📌 Commit 6582299 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - rust-lang#69425 (add fn make_contiguous to VecDeque) - rust-lang#69458 (improve folder name for persistent doc tests) - rust-lang#70268 (Document ThreadSanitizer in unstable-book) - rust-lang#70600 (Ensure there are versions of test code for aarch64 windows) - rust-lang#70606 (Clean up E0466 explanation) - rust-lang#70614 (remove unnecessary relocation check in const_prop) - rust-lang#70623 (Fix broken link in README) Failed merges: r? @ghost
No description provided.