Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RELEASES.md for 1.43.0 #70354

Merged
merged 12 commits into from
Apr 16, 2020
Merged

Update RELEASES.md for 1.43.0 #70354

merged 12 commits into from
Apr 16, 2020

Conversation

XAMPPRocky
Copy link
Member

Rendered

r? @Mark-Simulacrum

cc @rust-lang/release

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2020
kellerkindt
kellerkindt reviewed Mar 24, 2020
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
LeSeulArtichaut
LeSeulArtichaut reviewed Mar 24, 2020
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
XAMPPRocky and others added 3 commits March 24, 2020 16:07
@XAMPPRocky @LeSeulArtichaut
Apply suggestions from code review
f1f91c9 
Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>
@XAMPPRocky
Update RELEASES.md
1d2fbbe
@XAMPPRocky @LeSeulArtichaut
Update RELEASES.md
53790bb 
Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>
Mark-Simulacrum
Mark-Simulacrum reviewed Mar 24, 2020
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
@ehuss
Copy link
Contributor

ehuss commented Mar 24, 2020

I was wondering if it would be OK to include the addition of config-profiles in Cargo? It's a fairly straightforward change where the [profile] tables can now be specified in .cargo/config files. This also means that profiles can be modified with environment variables like CARGO_PROFILE_RELEASE_LTO=true. Stabilization PR and documentation.

Also, there's another, smaller change: The environment variable CARGO_BIN_EXE_<name> is set when compiling integration tests so that they can find the path to a package's executables. I'd like to encourage people to use that instead of contortions such as examining env::current_exe(). PR and docs.

XAMPPRocky and others added 3 commits March 24, 2020 18:23
@XAMPPRocky @Mark-Simulacrum
Update RELEASES.md
5baef96 
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
@XAMPPRocky @Mark-Simulacrum
Update RELEASES.md
f24cc7b 
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
@XAMPPRocky
Update RELEASES.md
f4e17cc
@XAMPPRocky
Copy link
Member Author

@ehuss Added those items.

Centril
Centril reviewed Mar 24, 2020
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@XAMPPRocky @Centril
Update RELEASES.md
ce3193f 
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@Mark-Simulacrum
Copy link
Member

Please add a compatibility note for #69548 as it is a breaking change for a few crates.

@Mark-Simulacrum
Copy link
Member

Also, it sounds like #69340 should also be added to the compatibility notes -- see #70443 and #70444 for some sample error logs.

tspiteri
tspiteri reviewed Mar 27, 2020
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
Mark-Simulacrum
Mark-Simulacrum reviewed Apr 11, 2020
View reviewed changes
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few nits left but overall looks good. Thanks!

RELEASES.md Outdated Show resolved Hide resolved
@XAMPPRocky
Copy link
Member Author

Should be ready to merge now.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 15, 2020

📌 Commit dda3445 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2020
@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 15, 2020
@Mark-Simulacrum Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 15, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2020
@bors
Auto merge of rust-lang#71180 - Dylan-DPC:rollup-pscpg6q, r=Dylan-DPC
ce1ab35 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#69903 (Do not ICE in the face of invalid enum discriminant)
 - rust-lang#70354 (Update RELEASES.md for 1.43.0)
 - rust-lang#70774 (End cleanup on rustdoc-js tools)
 - rust-lang#70990 (Improve rustdoc source code a bit)
 - rust-lang#71145 (Add illumos triple)
 - rust-lang#71166 (Clean up E0518 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 3c6e193 into rust-lang:master Apr 16, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Apr 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2020
@bors
Auto merge of rust-lang#71258 - Mark-Simulacrum:beta-next, r=Mark-Sim…
062dea0 
…ulacrum

[beta] backports

This includes:
* Do not reuse post LTO products when exports change rust-lang#71131
* macro_rules: `NtLifetime` cannot start with an identifier rust-lang#70768
* Update RELEASES.md for 1.43.0 rust-lang#70354

r? @ghost
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@kellerkindt kellerkindt kellerkindt left review comments

@BatmanAoD BatmanAoD BatmanAoD left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@tspiteri tspiteri tspiteri left review comments

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@XAMPPRocky @ehuss @Mark-Simulacrum @bors @Centril @kellerkindt @BatmanAoD @tspiteri @LeSeulArtichaut @rust-highfive