Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #71828

Merged
merged 15 commits into from
May 3, 2020
Merged

Rollup of 5 pull requests #71828

merged 15 commits into from
May 3, 2020

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

lcnr and others added 15 commits May 2, 2020 18:16
`slice::fill`: use `T` instead of generic arg

implements rust-lang#70758 (comment)

As the discussion in rust-lang#70758 has shifted, I now use `T` instead of `&T`.
Implement RFC 2523, `#[cfg(version(..))]`

Hi! This is my first contribution to rust, I hope I didn't miss anything. I tried to implement this feature so that `#[cfg(version(1.44.0))]` works but the parser was printing an error that I wasn't sure how to fix so I just opted for implementing `#[cfg(version("1.44.0"))]` (note the quotes).

Tracking issue: rust-lang#64796
…chenkov

Implement `confusable_idents` lint.

This collects all identifier symbols into `ParseSession` and examines them within the non-ascii-idents lint.

The skeleton generation part needs to be added to `unicode-security` crate. Will update this PR when the crate is updated.

r? @petrochenkov

EDIT: also included the `concat_idents` part.
Decode qualifs for associated const defaults

Fixes rust-lang#71734.

We encode qualifs for associated constants, but never expected to decode the qualifs for defaulted associated consts. Fix this, and test that associated const defaults have the correct qualifs cross-crate.

r? @tmandry
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented May 3, 2020

📌 Commit e48a7b8 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 3, 2020
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented May 3, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented May 3, 2020

📌 Commit e48a7b8 has been approved by Dylan-DPC

@bors
Copy link
Contributor

bors commented May 3, 2020

⌛ Testing commit e48a7b8 with merge d626e4d...

@bors
Copy link
Contributor

bors commented May 3, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing d626e4d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 3, 2020
@bors bors merged commit d626e4d into rust-lang:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants