Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] 1.45 release #74297

Merged
merged 2 commits into from
Jul 13, 2020
Merged

[stable] 1.45 release #74297

merged 2 commits into from
Jul 13, 2020

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Jul 13, 2020 •
edited
Loading

No description provided.

@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=1000 rollup=never

@bors
Copy link
Contributor

bors commented Jul 13, 2020

📌 Commit ab887cf has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 13, 2020

🌲 The tree is currently closed for pull requests below priority 20, this pull request will be tested once the tree is reopened

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 13, 2020
@bors
Copy link
Contributor

bors commented Jul 13, 2020

⌛ Testing commit ab887cf with merge d9f945dc9952bf774caedd92c85b7620e0a5525b...

@bors
Copy link
Contributor

bors commented Jul 13, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors retry - network "curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to ci-mirrors.rust-lang.org:443 "

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2020
@bors
Copy link
Contributor

bors commented Jul 13, 2020

⌛ Testing commit ab887cf with merge 5c1f21c...

MikailBag
MikailBag reviewed Jul 13, 2020
View reviewed changes
RELEASES.md
// Prints "abcdefghijklmnopqrstuvwxyz"
```
- [`OsString` now implements `FromStr`.][71662]
- [The `saturating_neg` method as been added to all signed integer primitive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [The `saturating_neg` method as been added to all signed integer primitive
- [The `saturating_neg` method has been added to all signed integer primitive

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to file a PR against master -- it won't make it into this stable release, but it should make it into the next one. Thanks!

@bors
Copy link
Contributor

bors commented Jul 13, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 5c1f21c to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 13, 2020
@bors bors merged commit 5c1f21c into rust-lang:stable Jul 13, 2020
@Mark-Simulacrum Mark-Simulacrum deleted the stable-next branch July 13, 2020 20:12
@cuviper cuviper added this to the 1.45 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikailBag MikailBag MikailBag left review comments

Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Simulacrum @bors @MikailBag @cuviper