Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the profiler on FreeBSD #74844

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Jul 27, 2020

FreeBSD has been doing this in our own package builds for two months
now.

https://svnweb.freebsd.org/ports?view=revision&revision=535771

FreeBSD has been doing this in our own package builds for two months
now.

https://svnweb.freebsd.org/ports?view=revision&revision=535771
@rust-highfive
Copy link
Collaborator

r? @pietroalbini

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2020
@pietroalbini
Copy link
Member

Seems fine, thanks for the PR!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 31, 2020

📌 Commit 013e1a6 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2020
@bors
Copy link
Contributor

bors commented Jul 31, 2020

⌛ Testing commit 013e1a6 with merge 62f9aa9...

@asomers
Copy link
Contributor Author

asomers commented Jul 31, 2020

W00t! Thanks @pietroalbini ! Now I'll be able to use gcov instead of kcov with my Rust projects.

@bors
Copy link
Contributor

bors commented Jul 31, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pietroalbini
Pushing 62f9aa9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2020
@bors bors merged commit 62f9aa9 into rust-lang:master Jul 31, 2020
@asomers asomers deleted the freebsd-profiler branch August 1, 2020 02:23
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants