Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows-gnu host cross-compilation #75625

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Aug 17, 2020

Fixes #64218

Also turns out it's faster to run Linux virtual machine on Windows and cross-compile ./x.py dist than doing it on Windows directly...

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2020
@lcnr
Copy link
Contributor

lcnr commented Aug 17, 2020

Not something I know much about.

r? @Mark-Simulacrum maybe

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2020

📌 Commit fbce878 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2020
@bors
Copy link
Contributor

bors commented Aug 24, 2020

⌛ Testing commit fbce878 with merge 3cf8f69...

@bors
Copy link
Contributor

bors commented Aug 25, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 3cf8f69 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2020
@bors bors merged commit 3cf8f69 into rust-lang:master Aug 25, 2020
@bors bors mentioned this pull request Aug 25, 2020
@mati865 mati865 deleted the mingw-cross-compile branch August 25, 2020 05:05
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM doesn't build on the first try when cross compilling to windows-gnu host
6 participants