Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #76557

Closed
wants to merge 24 commits into from
Closed

Commits on Sep 8, 2020

  1. rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars sinc…

    …e they are no longer supported by llvm
    
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        PYTHON_EXECUTABLE
        WITH_POLLY
    matthiaskrgr committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    0065e33 View commit details
    Browse the repository at this point in the history
  2. Implementation of peer credentials for Unix sockets

    The code in `ucred.rs` is based on the work done in PR 13 in the
    tokio-uds repository on GitHub. Link below for reference:
    
        tokio-rs/tokio-uds#13
    
    Credit to Martin Habovštiak (GitHub username Kixunil) and contributors
    for this work!
    Joe Ellis committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    968dd73 View commit details
    Browse the repository at this point in the history
  3. Remove use of MaybeUninit in ucred.rs

    We can simply init the struct directly. There is no real need to use
    uninit memory here.
    Joe Ellis committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    bd88f3f View commit details
    Browse the repository at this point in the history
  4. Add basic test for Unix peer credentials

    Joe Ellis committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    a699219 View commit details
    Browse the repository at this point in the history
  5. Use u32::MAX instead of u32::max_value

    Co-authored-by: lzutao <taolzu@gmail.com>
    2 people authored and Joe Ellis committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    55f1c2a View commit details
    Browse the repository at this point in the history
  6. Add pid as an option to UCred struct

    Currently, PID will be populated for Linux, and set to None for BSDs.
    Joe Ellis committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    010fd97 View commit details
    Browse the repository at this point in the history
  7. Move Unix peer credentials tests to their own file

    Joe Ellis committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    410124b View commit details
    Browse the repository at this point in the history
  8. Add documentation to public fields of UCred struct

    Joe Ellis committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    9113ebf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    217bf67 View commit details
    Browse the repository at this point in the history
  10. Use intra-doc links in core::ptr

    The only link that I did not change is a link to a function on the
    `pointer` primitive because intra-doc links for the `pointer` primitive
    don't work yet (see rust-lang#63351).
    camelid committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    325acef View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Add -Zgraphviz_dark_mode

    Many developers use a dark theme with editors and IDEs, but this
    typically doesn't extend to graphviz output.
    
    When I bring up a MIR graphviz document, the white background is
    strikingly bright. This new option changes the colors used for graphviz
    output to work better in dark-themed UIs.
    richkadel committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    c19b237 View commit details
    Browse the repository at this point in the history
  2. Fix broken link

    `write` is ambiguous because there's also a macro called `write`.
    
    Also removed unnecessary and potentially confusing link to a function in
    its own docs.
    camelid committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    d24026b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    10d3f8a View commit details
    Browse the repository at this point in the history
  4. Fix anchor links

    #safety -> self#safety
    camelid committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    884a1b4 View commit details
    Browse the repository at this point in the history
  5. Also fixed monospace font for d3-graphviz engine

    VS code graphviz extensions use d3-graphviz, which supports `Courier`
    fontname but does not support `monospace`. This caused graphs to render
    poorly because the text sizes were wrong.
    richkadel committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    f7aee33 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f42dac0 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Revert "Rollup merge of rust-lang#76285 - matklad:censor-spacing, r=p…

    …etrochenkov"
    
    This reverts commit 85cee57, reversing
    changes made to b4d3873.
    tmandry committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    fdff7de View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#74787 - petrochenkov:rustllvm, r=cuviper

    Move `rustllvm` into `compiler/rustc_llvm`
    
    The `rustllvm` directory is not self-contained, it contains C++ code built by a build script of the `rustc_llvm` crate which is then linked into that crate.
    So it makes sense to make `rustllvm` a part of `rustc_llvm` and move it into its directory.
    I replaced `rustllvm` with more obvious `llvm-wrapper` as the subdirectory name, but something like `llvm-adapter` would work as well, other suggestions are welcome.
    
    To make things more confusing, the Rust side of FFI functions defined in `rustllvm` can be found in `rustc_codegen_llvm` rather than in `rustc_llvm`. Perhaps they need to be moved as well, but this PR doesn't do that.
    
    The presence of multiple LLVM-related directories in `src` (`llvm-project`, `rustllvm`, `librustc_llvm`, `librustc_codegen_llvm` and their predecessors) historically confused me and made me wonder about their purpose.
    With this PR we will have LLVM itself (`llvm-project`), a FFI crate (`rustc_llvm`, kind of `llvm-sys`) and a codegen backend crate using LLVM through the FFI crate (`rustc_codegen_llvm`).
    tmandry committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    7074e02 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#75148 - joechrisellis:master, r=Amanieu

    Implementation of peer credentials for Unix sockets
    
    The code in `ucred.rs` is based on the work done in [PR 13](tokio-rs/tokio-uds#13) in the tokio-uds repository on GitHub.
    
    This commit is effectively a port to the stdlib, so credit to Martin Habovštiak (@Kixunil) and contributors for the meat of this work. 🥇
    
    Happy to make changes as needed. 🙂
    tmandry committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    1d5a5c5 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#76472 - matthiaskrgr:llvm_cmake_vars, r=Mar…

    …k-Simulacrum
    
    rustbuild: don't set PYTHON_EXECUTABLE and WITH_POLLY cmake vars since they are no longer supported by llvm
    
    This resolves
    
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        PYTHON_EXECUTABLE
        WITH_POLLY
    tmandry committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    eaaac83 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#76497 - camelid:intra-doc-links-for-core-pt…

    …r, r=jyn514
    
    Use intra-doc links in `core::ptr`
    
    Part of rust-lang#75080.
    
    The only link that I did not change is a link to a function on the
    `pointer` primitive because intra-doc links for the `pointer` primitive
    don't work yet (see rust-lang#63351).
    
    ---
    
    @rustbot modify labels: A-intra-doc-links T-doc
    tmandry committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    966fb1c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#76500 - richkadel:mir-graphviz-dark, r=tmandry

    Add -Zgraphviz_dark_mode and monospace font fix
    
    Many developers use a dark theme with editors and IDEs, but this
    typically doesn't extend to graphviz output.
    
    When I bring up a MIR graphviz document, the white background is
    strikingly bright. This new option changes the colors used for graphviz
    output to work better in dark-themed UIs.
    
    <img width="1305" alt="Screen Shot 2020-09-09 at 3 00 31 PM" src="https://user-images.githubusercontent.com/3827298/92659478-4b9bff00-f2ad-11ea-8894-b40d3a873cb9.png">
    
    Also fixed the monospace font for common graphviz renders (e.g., VS Code extensions), as described in rust-lang#76500 (comment)
    
    **Before:**
    <img width="943" alt="Screen Shot 2020-09-09 at 2 48 44 PM" src="https://user-images.githubusercontent.com/3827298/92658939-47231680-f2ac-11ea-97ac-96727e4dd622.png">
    
    **Now with fix:**
    <img width="943" alt="Screen Shot 2020-09-09 at 2 49 02 PM" src="https://user-images.githubusercontent.com/3827298/92658959-51451500-f2ac-11ea-9aae-de982d466d6a.png">
    tmandry committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    6e7d47d View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#76543 - ssomers:btree_cleanup_4, r=Mark-Sim…

    …ulacrum
    
    Document btree's unwrap_unchecked
    
    rust-lang#74693's second wind
    tmandry committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    dd4627a View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#76556 - tmandry:revert-76285, r=tmandry

    Revert rust-lang#76285
    
    Fixes rust-lang#76399. Reverting because the issue is P-critical and there are no PRs up to fix it.
    
    r? @Mark-Simulacrum
    cc @matklad @dtolnay
    tmandry committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2fc404f View commit details
    Browse the repository at this point in the history