Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements in liveness pass #77229

Merged
merged 7 commits into from
Sep 27, 2020
Merged

Small improvements in liveness pass #77229

merged 7 commits into from
Sep 27, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Sep 26, 2020 •
edited
Loading

  • Remove redundant debug logging (add_variable already contains logging).
  • Remove redundant fields for a number of live nodes and variables.
  • Delay conversion from a symbol to a string until linting.
  • Inline contents of specials struct.
  • Remove unnecessary local variable exit_ln.
  • Use newtype_index for Variable and LiveNode.
  • Access live nodes directly through self.lnks[ln].

No functional changes intended (except those related to the logging).

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2020
lcnr
lcnr approved these changes Sep 26, 2020
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esp 👍 on using symbols instead of Strings.

lcnr
lcnr approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after once the last small nit is addressed

compiler/rustc_passes/src/liveness.rs Outdated Show resolved Hide resolved
@lcnr
Copy link
Contributor

lcnr commented Sep 27, 2020

Thanks 👍

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 27, 2020

📌 Commit d68aa22 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2020
@jonas-schievink
Copy link
Contributor

This seems like it might slightly improve performance, so @bors rollup=never

@tmiasko tmiasko mentioned this pull request Sep 27, 2020
Merged
@bors
Copy link
Contributor

bors commented Sep 27, 2020

⌛ Testing commit d68aa22 with merge 7f7a1cb...

@bors
Copy link
Contributor

bors commented Sep 27, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: lcnr
Pushing 7f7a1cb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2020
@bors bors merged commit 7f7a1cb into rust-lang:master Sep 27, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 27, 2020
@tmiasko tmiasko deleted the liveness branch September 27, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr approved these changes

Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tmiasko @rust-highfive @lcnr @bors @jonas-schievink @rustbot