add error_occured field to ConstQualifs, #78809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
vn-ki
commented
Nov 6, 2020
| @@ -0,0 +1,3 @@ | |||
| struct Bug([u8; panic!(1)]); //~ ERROR panicking in constants is unstable | |||
There was a problem hiding this comment.
Not sure what a good test case is, in this case. So I added the one from the issue.
There was a problem hiding this comment.
This is a good test case. This PR does not yet fix struct Bug([u8; {let x; x}]);, so there are no other tests to add
oli-obk
reviewed
Nov 6, 2020
oli-obk
reviewed
Nov 6, 2020
vn-ki
force-pushed
the
fix-issue-76064
branch
3 times, most recently
from
8d409f3
to
0c56372
Compare
|
@bors r+ |
|
📌 Commit 0c56372 has been approved by |
bors
added
S-waiting-on-bors
bors
added
S-waiting-on-author
|
You need to rebase and re-bless, looks like we got another test added in the mean time |
|
Looks like the the new test still haven't been merged? |
|
Ah... this is a test from another PR? @bors r+ rollup=iffy |
|
📌 Commit 0c56372 has been approved by |
bors
added
S-waiting-on-bors
|
Is it not? I could not find that file in the repo. |
|
Oh, my bad. I was looking in the wrong place. It was inside the clippy tests. I didn't look inside there. |
|
@bors r- |
bors
added
S-waiting-on-author
vn-ki
force-pushed
the
fix-issue-76064
branch
from
0c56372
to
f026d0f
Compare
|
@oli-obk I've fixed the test. |
|
@bors r+ |
|
📌 Commit f026d0f has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit f026d0f with merge a439b5b1ca6ec3543584169639e0ccdc7f278b8b... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Nov 16, 2020
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 20, 2020
add error_occured field to ConstQualifs, fix rust-lang#76064 I wasn't sure what `in_return_place` actually did and not sure why it returns `ConstQualifs` while it's sibling functions return `bool`. So I tried to make as minimal changes to the structure as possible. Please point out whether I have to refactor it or not. r? `@oli-obk` cc `@RalfJung`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #76064
I wasn't sure what
in_return_placeactually did and not sure why it returnsConstQualifswhile it's sibling functions returnbool. So I tried to make as minimal changes to the structure as possible. Please point out whether I have to refactor it or not.r? @oli-obk
cc @RalfJung