BTreeMap: clean up implementation of clone #81276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
ssomers
commented
Jan 22, 2021
| @@ -149,40 +149,34 @@ impl<K: Clone, V: Clone> Clone for BTreeMap<K, V> { | |||
| fn clone(&self) -> BTreeMap<K, V> { | |||
| fn clone_subtree<'a, K: Clone, V: Clone>( | |||
There was a problem hiding this comment.
Previously support functions have move to support modules to downsize map.rs, but I don't know where to move this.
|
I forgot to mention one difference, an empty allocated map is no longer cloned as an unallocated map, and failed to realize another: a panic in clone no longer involves cleanup of the stuff already cloned. |
Mark-Simulacrum
added
S-waiting-on-author
ssomers
force-pushed
the
btree_cleanup_clone
branch
from
9414135
to
a623464
Compare
ssomers
force-pushed
the
btree_cleanup_clone
branch
from
a623464
to
35c7567
Compare
|
☔ The latest upstream changes (presumably #81257) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation has dodged waves of refactoring by dressing to intimidate.
r? @Mark-Simulacrum