Make rustdoc respect --error-format short in doctests
#81675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
jyn514
changed the title
--error-format short--error-format short in doctests
The other two (`human` and `json`) are already handled.
poliorcetics
force-pushed
the
respect-shortness
branch
from
b452e75
to
360f8f8
Compare
rustbot
added
A-doctests
|
Can you add a UI test for this in src/test/rustdoc-ui? |
|
r=me with CI passing (please use @bors delegate=poliorcetics |
|
✌️ @poliorcetics can now approve this pull request |
|
Should it be rolled up ? |
|
I don't think it should be marked rollup=always, no, since it has logic changes. It can still get rolled up if someone chooses to. @bors r+ |
|
📌 Commit 716d2cd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#80011 (Stabilize `peekable_next_if`) - rust-lang#81580 (Document how `MaybeUninit<Struct>` can be initialized.) - rust-lang#81610 (BTreeMap: make Ord bound explicit, compile-test its absence) - rust-lang#81664 (Avoid a hir access inside get_static) - rust-lang#81675 (Make rustdoc respect `--error-format short` in doctests) - rust-lang#81753 (Never MIR inline functions with a different instruction set) - rust-lang#81795 (Small refactor with Iterator::reduce) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Feb 24, 2021
Pass the error message format to rustdoc - Goes with rust-lang/rust#81675. - Will help with rust-lang/rust#81662. This is my first PR to Cargo and I haven't finished reading the contributor guide yet, how should I add tests for this ? Did I had the code in the correct place ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this will not work with
cargo test, only withrustdoc --test, I'll have to modifycargoas well.Fix #81662.
@rustbot label +T-rustdoc +A-doctests