Refactor PrimitiveTypeTable for Clippy

[camsteffen]

I removed PrimitiveTypeTable and added PrimTy::ALL and PrimTy::from_name in its place. This allows Clippy to use PrimTy::from_name for the builtin_type_shadow lint, and a const list of primitive types is deleted from Clippy code (the goal). All changes should be a little faster, if anything.

[rust-highfive]

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

configure: rust.channel         := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Diff in /checkout/compiler/rustc_resolve/src/diagnostics.rs at line 718:
                         );
                     }
                 }
-                Scope::BuiltinTypes => suggestions.extend(PrimTy::ALL.iter().filter_map(|prim_ty| {
-                    let res = Res::PrimTy(*prim_ty);
-                    filter_fn(res).then_some(TypoSuggestion::from_res(prim_ty.name(), res))
-                })),
+                Scope::BuiltinTypes => {
+                    suggestions.extend(PrimTy::ALL.iter().filter_map(|prim_ty| {
+                        let res = Res::PrimTy(*prim_ty);
Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/compiler/rustc_resolve/src/diagnostics.rs"` failed.
If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead.
+                        filter_fn(res).then_some(TypoSuggestion::from_res(prim_ty.name(), res))
+                    }))
             }
 
             None::<()>
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --stage 2 src/tools/tidy

[oli-obk]

Great refactoring!

Could you also add some documentation on the new constant and function? Other than those nits, r=me

[camsteffen]

Good! I wasn't sure if the associated const was kosher. 😄

Changes made.

[oli-obk]

@bors r+

[bors]

📌 Commit f66115d has been approved by oli-obk