Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #82200

Closed
wants to merge 134 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
134 commits
Select commit Hold shift + click to select a range
d00ca11
Add 'consider using' message to overflowing_literals
camelid Dec 12, 2020
949b125
Add unit tests for new lint
nahuakang Jan 27, 2021
5753614
Draft skeleton for new lint
nahuakang Jan 27, 2021
3da25ed
Rename lint
nahuakang Jan 27, 2021
8973f2c
Run cargo dev update_lints
nahuakang Jan 27, 2021
b87e189
Implement manual flatten lint
nahuakang Jan 29, 2021
7825bf3
Fix suggestions that need parens
ThibsG Jan 31, 2021
e07cd5b
Enhance manual flatten
nahuakang Feb 2, 2021
c8cb90a
Merge commit '3e4179766bcecd712824da04356621b8df012ea4' into sync-fro…
Manishearth Feb 3, 2021
0f5e71f
Add additional check on if arg type has iter method
nahuakang Feb 3, 2021
f2e82af
Use PrimTy in builtin type shadow lint
camsteffen Feb 2, 2021
6396b8f
Fix file names of flat_map_identity test
magurotuna Feb 3, 2021
876ffa4
Auto merge of #6669 - magurotuna:fix-test-name, r=flip1995
bors Feb 3, 2021
78ef0f2
Add additional test cases and improve span lint
nahuakang Feb 3, 2021
0767a0f
Fix/allow non_fmt_panic in clippy tests.
m-ou-se Feb 2, 2021
9f7f8b7
Suggest panic!("{}", ..) instead of panic!(..) clippy::expect_fun_call.
m-ou-se Feb 3, 2021
2f8a8d3
Improve lint message; add note for future autofixable updates
nahuakang Feb 4, 2021
357c6a7
Auto merge of #6646 - nahuakang:for_loops_over_options_or_results, r=…
bors Feb 4, 2021
233fe11
Set turbofish for every sugg and add more test cases
ThibsG Feb 4, 2021
7b7e3ca
Support free functions in disallowed-methods lint
phlip9 Jan 30, 2021
67d48e1
fix typo
TaKO8Ki Feb 5, 2021
79dbf10
Use absolute path to Rust repo in ra_setup
flip1995 Feb 5, 2021
56f7fbb
Cleanup path to local checks
camsteffen Feb 2, 2021
89f266a
Auto merge of #6678 - TaKO8Ki:fix-typo, r=flip1995
bors Feb 5, 2021
a507c27
Auto merge of #6679 - flip1995:ra_setup_abs_path, r=Manishearth
bors Feb 5, 2021
eb9c669
First version of the lint
1c3t3a Dec 20, 2020
f907986
Added documentation
1c3t3a Dec 21, 2020
55bfaa1
Fixed macro edge case for `semicolon_if_nothing_returned lint`
1c3t3a Feb 5, 2021
ac5e9c8
Fix let_underscore_drop implements Drop logic
camsteffen Feb 5, 2021
a9ad492
Bump clippy version
Mark-Simulacrum Feb 5, 2021
93daf27
tests: ignore check_that_clippy_has_the_same_major_version_as_rustc()…
matthiaskrgr Feb 5, 2021
a60c143
Add new lint `filter_map_identity`
magurotuna Feb 3, 2021
fbe436b
Use flatten instead of filter_map
magurotuna Feb 6, 2021
cb30219
lintcheck: update logs
matthiaskrgr Feb 6, 2021
64982cc
lintcheck: make TomlCrate also accept git-data from lintcheck_crates.…
matthiaskrgr Feb 5, 2021
10fbafa
implement the download_and_extract() step for git sources
matthiaskrgr Feb 6, 2021
9ab505a
lintcheck: add git source as an example and update logs
matthiaskrgr Feb 6, 2021
e1c284b
lintcheck: cleanup, fix --only for git crates, better error msgs
matthiaskrgr Feb 6, 2021
6626295
Fixed for loop problem, corrected all occurences that got linted
1c3t3a Feb 6, 2021
dfb34c0
Auto merge of #6684 - matthiaskrgr:versiontest_dont_break_upstream, r…
bors Feb 6, 2021
cd67487
Revert "Fixed for loop problem, corrected all occurences that got lin…
1c3t3a Feb 6, 2021
85c2b1e
Switched to `snippet_with_macro_callsite`
1c3t3a Feb 6, 2021
a5d442c
Rollup merge of #81680 - camsteffen:primty, r=oli-obk
jonas-schievink Feb 6, 2021
f1c1584
Changed lint level to `restriction`
1c3t3a Feb 6, 2021
915e9b8
Fix cargo_common_metadata warning on `publish = false`.
daxpedda Jan 29, 2021
d4bc7d2
Test names were flipped.
daxpedda Feb 3, 2021
f0d3fd7
Implement `_cargo_ignore_publish`.
daxpedda Feb 3, 2021
8805931
Hide clippy configuration option.
daxpedda Feb 6, 2021
f2391a5
Change clippy configuration option.
daxpedda Feb 6, 2021
8b89087
Add test for `publish = true`.
daxpedda Feb 6, 2021
cd361a5
Add back `publish = false` to the old test.
daxpedda Feb 6, 2021
e2e33b4
Pick up `clippy.toml` in `ui-cargo` tests.
daxpedda Feb 6, 2021
3c8f754
Fux `toml_unknown_key` test.
daxpedda Feb 6, 2021
ea0b832
Document condition.
daxpedda Feb 6, 2021
fd8b5fa
Confused about my own explanation.
daxpedda Feb 6, 2021
2bffbfc
lintcheck: avoid dbg!() calls
matthiaskrgr Feb 6, 2021
0585c34
Stabilize workspace wrapper.
ehuss Feb 6, 2021
6b4789d
Fixed suggestion in macro invocations
1c3t3a Feb 6, 2021
40ce056
Eat dogfood
camsteffen Feb 5, 2021
dfe08f4
Update triagebot.toml to new label names
flip1995 Feb 6, 2021
d792210
Auto merge of #6682 - camsteffen:let-underscore-ref, r=llogiq
bors Feb 7, 2021
b36d1a4
Auto merge of #6688 - rust-lang:triagebot_update, r=phansch
bors Feb 7, 2021
d51db24
Auto merge of #6660 - camsteffen:path-to-local, r=llogiq
bors Feb 7, 2021
001185d
Auto merge of #6681 - 1c3t3a:1c3t3a-issue-6467, r=xFrednet,flip1995,p…
bors Feb 7, 2021
ad9ceee
Auto merge of #6685 - magurotuna:filter_map_identity, r=phansch
bors Feb 7, 2021
83b7b16
Auto merge of #6674 - phlip9:disallowed_functions, r=llogiq
bors Feb 7, 2021
c1ce78f
Auto merge of #6686 - matthiaskrgr:lintcheck_git, r=flip1995
bors Feb 7, 2021
6f3eeac
lintcheck: add a cmdline option --crates-toml <TOML PATH> to override…
matthiaskrgr Feb 7, 2021
1c3033d
add a new lint `bytes_nth`
TaKO8Ki Feb 7, 2021
de35c29
Auto merge of #6694 - matthiaskrgr:lintcheck-cfg, r=Manishearth
bors Feb 7, 2021
7e94641
Fix SourceMap::start_point
osa1 Feb 7, 2021
fd35517
Downgrade trivial_regex to nursery
dtolnay Feb 8, 2021
4bbd7e4
Auto merge of #6696 - dtolnay-contrib:regex, r=Manishearth
bors Feb 8, 2021
1d30422
Enhance LocalUsedVisitor to check closure bodies
camsteffen Feb 3, 2021
5db48a3
Refactor out UnusedSelfVisitor
camsteffen Feb 3, 2021
37555f8
Use path_to_local_id
camsteffen Feb 8, 2021
34b373d
Rename HIR UnOp variants
osa1 Feb 9, 2021
775ce47
Rename "good first issue" back to "good-first-issue"
flip1995 Feb 9, 2021
03a0dd5
Auto merge of #6704 - rust-lang:flip1995-patch-1, r=phansch
bors Feb 9, 2021
b932587
Add better turbofish extractor
ThibsG Feb 9, 2021
03737e2
Remove rustfmt from rust-toolchain file
flip1995 Feb 9, 2021
08b4d50
Auto merge of #6709 - rust-lang:flip1995-patch-1, r=matthiaskrgr
bors Feb 9, 2021
1eb79f3
Use longer lifetime in `try_report_from_nll` return type
matthewjasper Feb 9, 2021
638980a
Using tracing macros in placeholder_error.rs
matthewjasper Feb 9, 2021
c2066cf
Remove unnecessary note on errors
matthewjasper Feb 9, 2021
daab6db
Avoid repeating self type in placeholder error
matthewjasper Feb 9, 2021
94c11df
Report "nice" placeholder errors more often
matthewjasper Feb 9, 2021
9337d4f
Print closure signatures when reporting placeholder errors
matthewjasper Feb 9, 2021
0e371b8
Auto merge of #6698 - camsteffen:path-to-local, r=phansch
bors Feb 10, 2021
932cc08
Update clippy_lints/src/methods/bytes_nth.rs
TaKO8Ki Feb 10, 2021
5996ae1
add some test cases
TaKO8Ki Feb 10, 2021
9c0ae2a
Auto merge of #6687 - ehuss:stabilize-wrapper, r=flip1995
bors Feb 10, 2021
b5e4389
Auto merge of #6695 - TaKO8Ki:add-bytes-nth, r=phansch
bors Feb 10, 2021
94b8f23
Fix typo
alpaca-tc Feb 10, 2021
a6d6b1b
Auto merge of #6714 - alpaca-tc:fixed_tiny_typo, r=flip1995
bors Feb 10, 2021
3784cdf
Auto merge of #6657 - ThibsG:FromIterParens, r=llogiq
bors Feb 10, 2021
f852160
Keep existing names of regions in placeholder_error
matthewjasper Feb 10, 2021
beb49ba
Auto merge of #6650 - daxpedda:cargo-common-metadata-publish, r=flip1995
bors Feb 11, 2021
1025cd3
lintcheck toml: explain why tokei is commented out
matthiaskrgr Feb 9, 2021
c7241b6
lintcheck: make the log file be ${source-file}-logs.txt
matthiaskrgr Feb 9, 2021
cfe154b
start a clippy-dev readme and some rough info on how to use lintcheck
matthiaskrgr Feb 9, 2021
5e29aa6
lintcheck: add support for path sources
matthiaskrgr Feb 10, 2021
a6d493d
lintcheck: collect ICEs
matthiaskrgr Feb 10, 2021
8dbcffe
Auto merge of #6708 - matthiaskrgr:lintcheck, r=flip1995
bors Feb 11, 2021
00f9981
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 Feb 11, 2021
4efc454
Bump nightly version -> 2021-02-11
flip1995 Feb 11, 2021
70c0f90
Auto merge of #6718 - flip1995:rustup, r=flip1995
bors Feb 11, 2021
d2e2f64
Merge commit '70c0f90453701e7d6d9b99aaa1fc6a765937b736' into clippyup
flip1995 Feb 11, 2021
be1ed00
Add additional type info to mismatch err
JulianKnodt Feb 13, 2021
a9b16c6
Improve error and help messages
camelid Feb 14, 2021
a491f51
Use delay_span_bug for mismatched subst/hir arg
edward-shen Feb 15, 2021
f856224
Fix test issue reference
edward-shen Feb 15, 2021
a4b2faf
Revise HIR lowering comment
edward-shen Feb 15, 2021
c914952
Move some tests to more reasonable directories
c410-f3r Feb 15, 2021
aee1e59
Simplify pattern grammar by allowing nested leading vert
mark-i-m Feb 8, 2021
b86c5db
Implement reborrow for closure captures
arora-aman Feb 4, 2021
e39c3c0
Handle restricting closure origin
arora-aman Feb 9, 2021
1b86ad8
Treat read of COpy types via refs as not move in move-closure
arora-aman Feb 12, 2021
f99e152
Use iter::position in truncate_capture_for_move
arora-aman Feb 13, 2021
b97951b
Update w/ comments
JulianKnodt Feb 14, 2021
f520295
Remove ordering hint
JulianKnodt Feb 16, 2021
a98b22c
Add caveat to Path::display() about lossiness
Manishearth Feb 16, 2021
61bb183
Optimize Iterator::is_sorted_by by using Iterator::all for internal i…
SkiFire13 Feb 16, 2021
625410f
Rollup merge of #79981 - camelid:overflowing_literals-inference-error…
Dylan-DPC Feb 16, 2021
a03cda1
Rollup merge of #81860 - osa1:issue81800, r=estebank
Dylan-DPC Feb 16, 2021
f9f1f23
Rollup merge of #81869 - mark-i-m:leading-vert, r=petrochenkov
Dylan-DPC Feb 16, 2021
e13ed44
Rollup merge of #81941 - c410-f3r:tests-tests-tests, r=petrochenkov
Dylan-DPC Feb 16, 2021
3741971
Rollup merge of #81972 - matthewjasper:hrtb-error-cleanup, r=nikomats…
Dylan-DPC Feb 16, 2021
4de1fa2
Rollup merge of #81993 - flip1995:clippyup, r=Manishearth
Dylan-DPC Feb 16, 2021
7e8d0c6
Rollup merge of #82007 - sexxi-goose:reborrow, r=nikomatsakis
Dylan-DPC Feb 16, 2021
ddb2270
Rollup merge of #82055 - JulianKnodt:ty_where_const, r=estebank
Dylan-DPC Feb 16, 2021
b164a4a
Rollup merge of #82136 - edward-shen:mismatched-subst-and-hir, r=lcnr
Dylan-DPC Feb 16, 2021
41a0550
Rollup merge of #82196 - Manishearth:display-caveat, r=m-ou-se
Dylan-DPC Feb 16, 2021
5c6b8ae
Rollup merge of #82198 - SkiFire13:optimize-iter-is-sorted, r=sfackler
Dylan-DPC Feb 16, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions compiler/rustc_expand/src/expand.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use rustc_data_structures::stack::ensure_sufficient_stack;
use rustc_data_structures::sync::Lrc;
use rustc_errors::{Applicability, PResult};
use rustc_feature::Features;
use rustc_parse::parser::{AttemptLocalParseRecovery, ForceCollect, Parser};
use rustc_parse::parser::{AttemptLocalParseRecovery, ForceCollect, GateOr, Parser, RecoverComma};
use rustc_parse::validate_attr;
use rustc_session::lint::builtin::UNUSED_DOC_COMMENTS;
use rustc_session::lint::BuiltinLintDiagnostics;
Expand Down Expand Up @@ -914,7 +914,9 @@ pub fn parse_ast_fragment<'a>(
}
}
AstFragmentKind::Ty => AstFragment::Ty(this.parse_ty()?),
AstFragmentKind::Pat => AstFragment::Pat(this.parse_pat(None)?),
AstFragmentKind::Pat => {
AstFragment::Pat(this.parse_pat_allow_top_alt(None, GateOr::Yes, RecoverComma::No)?)
}
AstFragmentKind::Arms
| AstFragmentKind::Fields
| AstFragmentKind::FieldPats
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ impl<'cx, 'tcx> NiceRegionError<'cx, 'tcx> {
self.infcx.tcx
}

pub fn try_report_from_nll(&self) -> Option<DiagnosticBuilder<'cx>> {
pub fn try_report_from_nll(&self) -> Option<DiagnosticBuilder<'tcx>> {
// Due to the improved diagnostics returned by the MIR borrow checker, only a subset of
// the nice region errors are required when running under the MIR borrow checker.
self.try_report_named_anon_conflict().or_else(|| self.try_report_placeholder_conflict())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use rustc_middle::ty;
impl<'a, 'tcx> NiceRegionError<'a, 'tcx> {
/// When given a `ConcreteFailure` for a function with parameters containing a named region and
/// an anonymous region, emit an descriptive diagnostic error.
pub(super) fn try_report_named_anon_conflict(&self) -> Option<DiagnosticBuilder<'a>> {
pub(super) fn try_report_named_anon_conflict(&self) -> Option<DiagnosticBuilder<'tcx>> {
let (span, sub, sup) = self.regions()?;

debug!(
Expand Down
Loading