Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy: Add ignore-rules for the line length check #83549

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

sjakobi
Copy link
Contributor

@sjakobi sjakobi commented Mar 27, 2021

This is step 1 towards fixing #77548.

This PR contains the tidy change from #77675. The "ignoring file length unnecessarily" check is temporarily disabled to simplify landing the ignore-rules. This check will be re-enabled in a follow-up PR.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2021
@sjakobi
Copy link
Contributor Author

sjakobi commented Mar 27, 2021

r? @RalfJung

@RalfJung
Copy link
Member

RalfJung commented Mar 27, 2021

Thanks for the PR, but I am really not qualified to approve this. :)
r? @Mark-Simulacrum

@sjakobi sjakobi marked this pull request as ready for review March 27, 2021 12:40
@Mark-Simulacrum
Copy link
Member

r=me with commits squashed, thanks

This is step 1 towards fixing rust-lang#77548.

This commit includes the tidy change from rust-lang#77675.
The "ignoring file length unnecessarily" check is temporarily
disabled to simplify landing the ignore-rules.
That check will be re-enabled in a follow-up PR.
@sjakobi
Copy link
Contributor Author

sjakobi commented Apr 3, 2021

Squashed. Thanks for the review! :)

@RalfJung
Copy link
Member

RalfJung commented Apr 3, 2021

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Apr 3, 2021

📌 Commit c35a36f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2021
@bors
Copy link
Contributor

bors commented Apr 3, 2021

⌛ Testing commit c35a36f with merge ccd9975...

@bors
Copy link
Contributor

bors commented Apr 3, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ccd9975 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 3, 2021
@bors bors merged commit ccd9975 into rust-lang:master Apr 3, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 3, 2021
@sjakobi sjakobi deleted the no-tidy-line-length-1 branch April 3, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants