Dynamic memory allocation for enclaves running on SGXv2 processors #83927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
raoulstrackx
commented
Apr 6, 2021
| @@ -96,6 +96,10 @@ cargo = { path = "src/tools/cargo" } | |||
| rustfmt-nightly = { path = "src/tools/rustfmt" } | |||
|
|
|||
| [patch.crates-io] | |||
| fortanix-sgx-abi = { git = "https://github.com/fortanix/rust-sgx", branch = "raoul/edmm" } | |||
| sgx-isa = { git = "https://github.com/fortanix/rust-sgx", branch = "raoul/edmm" } | |||
| bitflags = { git = "https://github.com/bitflags/bitflags" } | |||
There was a problem hiding this comment.
bitflags patch can be removed once a new version is published on crates.io
raoulstrackx
commented
Apr 6, 2021
| @@ -96,6 +96,10 @@ cargo = { path = "src/tools/cargo" } | |||
| rustfmt-nightly = { path = "src/tools/rustfmt" } | |||
|
|
|||
| [patch.crates-io] | |||
| fortanix-sgx-abi = { git = "https://github.com/fortanix/rust-sgx", branch = "raoul/edmm" } | |||
| sgx-isa = { git = "https://github.com/fortanix/rust-sgx", branch = "raoul/edmm" } | |||
There was a problem hiding this comment.
Patches need to be removed when fortanix/rust-sgx#292 merges
raoulstrackx
commented
Apr 6, 2021
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct BuddyAllocator { |
There was a problem hiding this comment.
Should this move to a crate outside the compiler?
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☔ The latest upstream changes (presumably #83776) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Triage: ci can't pass in current form, and there's merge conflict now. |
crlf0710
added
S-waiting-on-author
Dylan-DPC-zz
removed
the
S-waiting-on-review
|
@raoulstrackx any updates? |
bstrie
added
S-waiting-on-author
|
@raoulstrackx I'm gonna close this due to inactivity. Feel free to reopen or create a new pr when you're ready to work on this again. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel SGX enclaves running on processors with only SGXv1 extensions, need to reserve all enclave memory they possibly need at enclave creation time. This requires enclave developers to estimate the worst case memory consumption and oversubscribe EPC memory.
On processors with SGXv2 extensions, enclaves may request/release enclave memory dynamically (i.e., after the enclave was created). Changes to enclave memory need to be tracked by both the enclave as the enclave runtime system (untrusted enclave runner, OS, SGX driver). This PR adds the required support for such enclaves. Changes are to the enclave runner and other closely related crates are made in: fortanix/rust-sgx#292.
cc: @jethrogb