Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generating allocas & memcmp for simple short array equality #85828

Merged
merged 9 commits into from
Jul 9, 2021
Merged

Stop generating allocas & memcmp for simple short array equality #85828

merged 9 commits into from
Jul 9, 2021

Commits on Jul 8, 2021

  1. Move the PartialEq and Eq impls for arrays to a separate file

    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d05eafa View commit details
    Browse the repository at this point in the history

  2. Stop generating allocas+memcmp for simple array equality

    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    2456495 View commit details
    Browse the repository at this point in the history

  3. PR feedback 

    - Add `:Sized` assertion in interpreter impl
- Use `Scalar::from_bool` instead of `ScalarInt: From<bool>`
- Remove unneeded comparison in intrinsic typeck
- Make this UB to call with undef, not just return undef in that case
    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    b63b2f1 View commit details
    Browse the repository at this point in the history

  4. Implement the raw_eq intrinsic in codegen_cranelift

    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    1216353 View commit details
    Browse the repository at this point in the history

  5. Add another codegen test, array_eq_zero 

    Showing that this avoids an alloca and private constant.
    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    039a3ba View commit details
    Browse the repository at this point in the history

  6. PR Feedback: Don't put SSA-only types in CValues

    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    3d2869c View commit details
    Browse the repository at this point in the history

  7. Use cranelift's Type::int instead of doing the match myself 

    <https://docs.rs/cranelift-codegen/0.74.0/cranelift_codegen/ir/types/struct.Type.html#method.int>
    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6444f24 View commit details
    Browse the repository at this point in the history

  8. Adjust the threshold to look at the ABI, not just the size

    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    07fb5ee View commit details
    Browse the repository at this point in the history

  9. Bless a UI test

    @scottmcm
    scottmcm committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d064494 View commit details
    Browse the repository at this point in the history