Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valgrind suppression on mac #8779

Merged
merged 1 commit into from
Aug 27, 2013
Merged

Fix valgrind suppression on mac #8779

merged 1 commit into from
Aug 27, 2013

Conversation

brson
Copy link
Contributor

@brson brson commented Aug 27, 2013

This callstack changed when the FFI did. I am still a little frightened by
this suppression.

cc #8253

This callstack changed when the FFI did. I am still a little frightened by
this suppression.
bors added a commit that referenced this pull request Aug 27, 2013
This callstack changed when the FFI did. I am still a little frightened by
this suppression.

cc #8253
@bors bors closed this Aug 27, 2013
@bors bors merged commit 7406c2d into rust-lang:master Aug 27, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 5, 2022
…ogiq

Easier readability for `needless_late_init` message

Closes rust-lang#8530

Updated the lint to use a `MultiSpan`, showing where the `let` statement was first used and where the initialisation statement was done, as in the format described, for easier readability.

Was wondering why, when pushing the span label for the initialisation statement, that sometimes the prior statement above the initialisation statement gets pulled into the output as well - any insight is appreciated!

---

changelog: [`needless_late_init`]: Now shows the `let` statement where it was first initialized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants