Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #88568

Closed
wants to merge 33 commits into from

Commits on Aug 8, 2021

  1. Update Windows arg parsing tests

    This updates the tests to be consistent with argv in modern C/C++ applications.
    ChrisDenton committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    565a519 View commit details
    Browse the repository at this point in the history
  2. Implement modern Windows arg parsing

    As derived from extensive testing of `argv` in a C/C++ application.
    
    Co-Authored-By: Jane Lusby <jlusby42@gmail.com>
    ChrisDenton and yaahc committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    e26dda5 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Configuration menu
    Copy the full SHA
    4870f06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8553c19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eb91366 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b99038f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Configuration menu
    Copy the full SHA
    32e639d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d988278 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b88ad42 View commit details
    Browse the repository at this point in the history
  4. Remove single use variables

    ptrojahn committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    99a3d64 View commit details
    Browse the repository at this point in the history
  5. add safety annotation to LinkedList::detach_all_nodes

    Co-authored-by: kennytm <kennytm@gmail.com>
    ibraheemdev and kennytm committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ffc43b8 View commit details
    Browse the repository at this point in the history
  6. Lint Abi in ast validation.

    cjgillot committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    8d7d488 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7189c85 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7d18052 View commit details
    Browse the repository at this point in the history
  9. Include debug info for the allocator shim

    Issue Details:
    In some cases it is necessary to generate an "allocator shim" to forward various Rust allocation functions (e.g., `__rust_alloc`) to an underlying function (e.g., `malloc`). However, since this allocator shim is a manually created LLVM module it is not processed via the normal module processing code and so no debug info is generated for it (if debugging info is enabled).
    
    Fix Details:
    * Modify the `debuginfo` code to allow creating debug info for a module without a `CodegenCx` (since it is difficult, and expensive, to create one just to emit some debug info).
    * After creating the allocator shim add in basic debug info.
    dpaoliello committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    77a96ed View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Configuration menu
    Copy the full SHA
    59b245e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7159bd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fba4149 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6c9e708 View commit details
    Browse the repository at this point in the history
  5. fix clippy lints

    klensy committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f5f489b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a5fd955 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    92dae39 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#87114 - cjgillot:abilint, r=estebank

    Lint missing Abi in ast validation instead of lowering.
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    6402071 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#87580 - ChrisDenton:win-arg-parse-2008, r=m…

    …-ou-se
    
    Update Windows Argument Parsing
    
    Fixes rust-lang#44650
    
    The Windows command line is passed to applications [as a single string](https://docs.microsoft.com/en-us/archive/blogs/larryosterman/the-windows-command-line-is-just-a-string) which the application then parses to get a list of arguments. The standard rules (as used by C/C++) for parsing the command line have slightly changed over the years, most recently in 2008 which added new escaping rules.
    
    This PR implements the new rules as [described on MSDN](https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=msvc-160#parsing-c-command-line-arguments) and [further detailed here](https://daviddeley.com/autohotkey/parameters/parameters.htm#WIN). It has been tested against the behaviour of C++ by calling a C++ program that outputs its raw command line and the contents of `argv`. See [my repo](https://github.com/ChrisDenton/winarg/tree/std) if anyone wants to reproduce my work.
    
    For an overview of how this PR changes argument parsing behavior and why we feel it is warranted see rust-lang#87580 (comment).
    
    For some examples see: rust-lang#87580 (comment)
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c08d0c0 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#88490 - GuillaumeGomez:associated-types-imp…

    …lementors-display, r=camelid,Manishearth
    
    Display associated types of implementors
    
    Fixes rust-lang#86631.
    
    Contrary to before, it doesn't display methods. I also had to "resurrect" the `auto-hide-trait-implementations` setting. :3
    
    Only question at this point: should I move the `render_impl` boolean arguments into one struct? We're starting to have quite a lot of them...
    
    cc `@cynecx`
    r? `@camelid`
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    9d052cb View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#88505 - ibraheemdev:use-unwrap-unchecked, r…

    …=kennytm
    
    Use `unwrap_unchecked` where possible
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    d9c75b1 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#88530 - bjorn3:shrink_session, r=cjgillot

    Shrink Session a bit
    
    Remove a couple of unnecessary fields from `Session` and remove a `Lock<T>` for a field that is never mutated anyway.
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    4f6211b View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#88532 - ptrojahn:single_use, r=davidtwco

    Remove single use variables
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    348305f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    bcd740c View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#88547 - notriddle:notriddle/is-expr-delims-…

    …necessary, r=davidtwco
    
    fix(rustc_lint): better detect when parens are necessary
    
    Fixes rust-lang#88519
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    30142cb View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#88550 - dpaoliello:dpaoliello/allocdebuginf…

    …o, r=estebank
    
    Include debug info for the allocator shim
    
    Issue Details:
    In some cases it is necessary to generate an "allocator shim" to forward various Rust allocation functions (e.g., `__rust_alloc`) to an underlying function (e.g., `malloc`). However, since this allocator shim is a manually created LLVM module it is not processed via the normal module processing code and so no debug info is generated for it (if debugging info is enabled).
    
    Fix Details:
    * Modify the `debuginfo` code to allow creating debug info for a module without a `CodegenCx` (since it is difficult, and expensive, to create one just to emit some debug info).
    * After creating the allocator shim add in basic debug info.
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    163c0c9 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#88560 - klensy:formatter-pad-shrink, r=m-ou-se

    `fmt::Formatter::pad`: don't call chars().count() more than one time
    
    First commit merges two branches of match to call chars().count() only once: that should be faster if this method hits place of 3rd (previous) branch, plus quarter shorter.
    Second commit fixes some clippy lints while i'm here (should it be separate PR?).
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    66ef9cc View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#88565 - lqd:issue-83190, r=spastorino

    Add regression test for issue 83190
    
    Reduced from `bioyino-metric` by `@hellow554` and myself.
    
    Closes rust-lang#83190.
    
    r? `@spastorino`
    GuillaumeGomez committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f230145 View commit details
    Browse the repository at this point in the history