Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed slice.swap documentation for better readability #90257

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

zommiommy
Copy link
Contributor

The example exchanges the letters "b" and "d", these can be easily confused and are hard to read for people with dyslexia.
Therefore, I changed the example to a more easily readable one.

This is just a small fix and it's not urgent by any means, but I spent 5 minutes trying to understand why I couldn't see any change so I fixed it.

Anyway, thank you for all your works!

using "b" and "d" can be easily confused
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Oct 25, 2021

Thank you!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 25, 2021

📌 Commit 32a3edb has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2021
@rust-log-analyzer

This comment has been minimized.

@zommiommy
Copy link
Contributor Author

SORRY MY BAD, I forgot the double quote.

@m-ou-se
Copy link
Member

m-ou-se commented Oct 25, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 25, 2021

📌 Commit 9b28ab4 has been approved by m-ou-se

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 25, 2021
Changed slice.swap documentation for better readability

The example exchanges the letters "b" and "d", these can be easily confused and are hard to read for people with dyslexia.
Therefore, I changed the example to a more easily readable one.

This is just a small fix and it's not urgent by any means, but I spent 5 minutes trying to understand why I couldn't see any change so I fixed it.

Anyway, thank you for all your works!
This was referenced Oct 25, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2021
…laumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#90017 (Add a couple tests for normalize under binder issues)
 - rust-lang#90079 (enable `i8mm` target feature on aarch64 and arm)
 - rust-lang#90233 (Tooltip overflow)
 - rust-lang#90257 (Changed slice.swap documentation for better readability)
 - rust-lang#90261 (Move back to linux builder on try builds)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3697624 into rust-lang:master Oct 25, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 25, 2021
@zommiommy zommiommy deleted the patch-1 branch November 10, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants