[beta] Backport Clippy lint renaming / regrouping #90561

flip1995 · 2021-11-04T11:37:00Z

This backports PR rust-lang/rust-clippy#7810 to beta, where a lint added in the 1.57 (current beta) release cycle was renamed shortly after the beta cutoff. We want to backport this, so we don't have unnecessary lint_store.registered_renamed calls in the Clippy codebase forever.

(The formatting changes were necessary to pass this backport in the Clippy CI, removing it in a subtree sync would be a bit painful...)

cc @camsteffen

…lip1995 Move if_then_panic to pedantic and rename to manual_assert

[beta] Backport: Move if_then_panic to pedantic and rename to manual_assert Backport of rust-lang#7810 cc `@camsteffen` r? `@ghost` changelog: none (same release)

…ackport

rust-highfive · 2021-11-04T11:37:03Z

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

rust-highfive · 2021-11-04T11:37:04Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2021-11-04T11:37:05Z

⚠️ Warning ⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

Mark-Simulacrum · 2021-11-04T13:23:09Z

@bors r+ rollup=never

This seems OK. I'd probably prefer to delete the newly introduced lint, reverting the patch introducing it, (rather than backporting the rename), but the changes are small enough that it doesn't seem that bad -- and the deletion would probably be closer to a revert but still likely to be larger, so not necessarily better.

bors · 2021-11-04T13:23:10Z

📌 Commit 4cd7ad0 has been approved by Mark-Simulacrum

bors · 2021-11-04T13:54:28Z

⌛ Testing commit 4cd7ad0 with merge e3d230e22989fe1400cd6d5d2c0397191912ab84...

rust-log-analyzer · 2021-11-04T14:20:56Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/38 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/38 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/38 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
tar: Error is not recoverable: exiting now
Sending build context to Docker daemon  504.3kB

Step 1/38 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2021-11-04T14:21:54Z

💔 Test failed - checks-actions

matthiaskrgr · 2021-11-04T17:06:54Z

@bors retry

bors · 2021-11-05T01:00:20Z

⌛ Testing commit 4cd7ad0 with merge b3ccf6469708d3839b2649435bb16e9eb4dd7575...

bors · 2021-11-05T01:29:33Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-11-05T01:29:42Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/38 : FROM debian:6
 ---> a873733ef581
---

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/38 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/38 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/38 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
##[error]Process completed with exit code 1.
Post job cleanup.

bors · 2021-11-07T11:24:30Z

⌛ Testing commit 4cd7ad0 with merge 4ff025b286415f50b401a161eb64f1d6a48d611f...

bors · 2021-11-07T11:53:21Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-11-07T11:54:55Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/40 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/40 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/40 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
Sending build context to Docker daemon  504.3kB

Step 1/40 : FROM debian:6
 ---> a873733ef581
---
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
The command '/bin/sh -c ./build-python.sh 3.9.1' returned a non-zero code: 2
##[error]Process completed with exit code 1.
Post job cleanup.

flip1995 · 2021-11-08T11:02:50Z

This seems like a general certificate issue with the beta branch. I'm not sure what to do here.

Mark-Simulacrum · 2021-11-08T12:08:41Z

We need to backport one of the fix PRs, most likely. I'll add it to my list.

Mark-Simulacrum · 2021-11-08T13:39:42Z

@bors r-

matthiaskrgr · 2021-11-19T12:02:43Z

let's try this again now that the beta backports with the python cert stuff was merged
@bors r=Mark-Simulacrum rollup=never

bors · 2021-11-19T12:02:44Z

📌 Commit 4cd7ad0 has been approved by Mark-Simulacrum

bors · 2021-11-19T14:53:13Z

⌛ Testing commit 4cd7ad0 with merge ef1a3b9...

bors · 2021-11-19T17:54:17Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ef1a3b9 to beta...

bors and others added 4 commits November 3, 2021 17:21

Auto merge of rust-lang#7810 - camsteffen:if-then-panic-pedantic, r=f…

e1225bf

…lip1995 Move if_then_panic to pedantic and rename to manual_assert

Format backport to pass CI

d23a338

Auto merge of rust-lang#7925 - flip1995:backport, r=flip1995

00e31fa

[beta] Backport: Move if_then_panic to pedantic and rename to manual_assert Backport of rust-lang#7810 cc `@camsteffen` r? `@ghost` changelog: none (same release)

Merge commit '00e31fa5af1895bf8ff1e2b1e25b041362cdc33e' into clippy_b…

4cd7ad0

…ackport

rust-highfive assigned Mark-Simulacrum Nov 4, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 5, 2021

bors mentioned this pull request Nov 7, 2021

Make std::thread::available_concurrency support process-limited number of CPUs #89310

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2021

apiraino added the A-clippy Area: Clippy label Nov 11, 2021

matthiaskrgr mentioned this pull request Nov 16, 2021

[beta] backports #90938

Merged

flip1995 mentioned this pull request Nov 16, 2021

[beta] Backport CI fixes for python certificates #90953

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 19, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 19, 2021

bors merged commit ef1a3b9 into rust-lang:beta Nov 19, 2021

rustbot added this to the 1.57.0 milestone Nov 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[beta] Backport Clippy lint renaming / regrouping #90561

[beta] Backport Clippy lint renaming / regrouping #90561

flip1995 commented Nov 4, 2021

rust-highfive commented Nov 4, 2021

rust-highfive commented Nov 4, 2021

rust-highfive commented Nov 4, 2021

Mark-Simulacrum commented Nov 4, 2021

bors commented Nov 4, 2021

bors commented Nov 4, 2021

rust-log-analyzer commented Nov 4, 2021

bors commented Nov 4, 2021

matthiaskrgr commented Nov 4, 2021

bors commented Nov 5, 2021

bors commented Nov 5, 2021

rust-log-analyzer commented Nov 5, 2021

bors commented Nov 7, 2021

bors commented Nov 7, 2021

rust-log-analyzer commented Nov 7, 2021

flip1995 commented Nov 8, 2021

Mark-Simulacrum commented Nov 8, 2021

Mark-Simulacrum commented Nov 8, 2021

matthiaskrgr commented Nov 19, 2021

bors commented Nov 19, 2021

bors commented Nov 19, 2021

bors commented Nov 19, 2021

[beta] Backport Clippy lint renaming / regrouping #90561

[beta] Backport Clippy lint renaming / regrouping #90561

Conversation

flip1995 commented Nov 4, 2021

rust-highfive commented Nov 4, 2021

rust-highfive commented Nov 4, 2021

rust-highfive commented Nov 4, 2021

Mark-Simulacrum commented Nov 4, 2021

bors commented Nov 4, 2021

bors commented Nov 4, 2021

rust-log-analyzer commented Nov 4, 2021

bors commented Nov 4, 2021

matthiaskrgr commented Nov 4, 2021

bors commented Nov 5, 2021

bors commented Nov 5, 2021

rust-log-analyzer commented Nov 5, 2021

bors commented Nov 7, 2021

bors commented Nov 7, 2021

rust-log-analyzer commented Nov 7, 2021

flip1995 commented Nov 8, 2021

Mark-Simulacrum commented Nov 8, 2021

Mark-Simulacrum commented Nov 8, 2021

matthiaskrgr commented Nov 19, 2021

bors commented Nov 19, 2021

bors commented Nov 19, 2021

bors commented Nov 19, 2021