Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clippy::single_char_pattern perf findings #91880

Merged
merged 1 commit into from
Dec 15, 2021
Merged

fix clippy::single_char_pattern perf findings #91880

merged 1 commit into from
Dec 15, 2021

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 13, 2021
@rust-highfive
Copy link
Collaborator

Some changes occurred in intra-doc-links.

cc @jyn514

@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2021
jyn514
jyn514 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the nit fixed :)

compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs Show resolved Hide resolved
src/librustdoc/html/render/cache.rs Outdated Show resolved Hide resolved
@jyn514 jyn514 assigned jyn514 and unassigned wesleywiser Dec 14, 2021
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2021
@matthiaskrgr
Copy link
Member Author

@bors r=jyn514

@bors
Copy link
Contributor

bors commented Dec 14, 2021

📌 Commit 97e844a has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91880 - matthiaskrgr:clippy_perf_dec, r=jyn514
d9f11aa 
fix clippy::single_char_pattern perf findings
This was referenced Dec 14, 2021
Closed
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91880 - matthiaskrgr:clippy_perf_dec, r=jyn514
ed84782 
fix clippy::single_char_pattern perf findings
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91880 - matthiaskrgr:clippy_perf_dec, r=jyn514
af11c6f 
fix clippy::single_char_pattern perf findings
This was referenced Dec 14, 2021
Closed
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 15, 2021
@matthiaskrgr
Rollup merge of rust-lang#91880 - matthiaskrgr:clippy_perf_dec, r=jyn514
38ae772 
fix clippy::single_char_pattern perf findings
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 15, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2021
@bors
Auto merge of rust-lang#91962 - matthiaskrgr:rollup-2g082jw, r=matthi…
c5ecc15 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91880 (fix clippy::single_char_pattern perf findings)
 - rust-lang#91885 (Remove `in_band_lifetimes` from `rustc_codegen_ssa`)
 - rust-lang#91898 (Make `TyS::is_suggestable` check for non-suggestable types structually)
 - rust-lang#91915 (Add another regression test for unnormalized fn args with Self)
 - rust-lang#91916 (Fix a bunch of typos)
 - rust-lang#91918 (Constify `bool::then{,_some}`)
 - rust-lang#91920 (Use `tcx.def_path_hash` in `ExistentialPredicate.stable_cmp`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9ca0bd5 into rust-lang:master Dec 15, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees

@jyn514 jyn514

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @rust-highfive @bors @jyn514 @wesleywiser @rustbot