Relax tests for Windows dos device names #94650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows 11 no longer turn paths ending with dos device names into device paths. E.g. `C:\path\to\COM1.txt` used to get turned into `\\.\COM1`. Whereas now the path is left as is.
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Just curious, have you seen any communication about this change from Microsoft? I haven't been able to find any, though it is a bit difficult to search for. |
|
As far as I'm aware there has been none so far. The first I heard of it was when @jstarks brought it up in conversation. Which then caused me to run tests and check how it works now. Honestly I'm pleasantly surprised. The less magic when handling paths the better. |
dtolnay
added
the
T-libs
|
@bors r+ |
|
📌 Commit 3009eec has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#93858 (Add a `process_group` method to UNIX `CommandExt`) - rust-lang#94650 (Relax tests for Windows dos device names) - rust-lang#94991 (Make Weak::new const) - rust-lang#95072 (Re-enable parallel debuginfo tests) - rust-lang#95109 (Extend --check-cfg tests to all predicate inside all/any) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 11 no longer turn paths ending with dos device names into device paths.
E.g.
C:\path\to\COM1.txtused to get turned into\\.\COM1. Whereas now this path is left as is.Note though that if the given path is an exact (case-insensitive) match for the string
COM1then it'll still be converted to\\.\COM1.