Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate function name in rustc_const_eval docs #95281

Merged
merged 1 commit into from
May 11, 2022

Conversation

pierwill
Copy link
Member

Looks to me like this fixes #85513. I had trouble making a intra-docs link to eval_place_to_op work, though...

@Dylan-DPC
Copy link
Member

r? @Dylan-DPC

@Dylan-DPC
Copy link
Member

@bors r+ rollup

1 similar comment
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@Dylan-DPC Dylan-DPC closed this Mar 25, 2022
@Dylan-DPC Dylan-DPC reopened this Mar 25, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

1 similar comment
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 26, 2022

📌 Commit 32b2a19 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 26, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 26, 2022
Fix inaccurate function name in `rustc_const_eval` docs

Looks to me like this fixes rust-lang#85513. I had trouble making a intra-docs link to `eval_place_to_op` work, though...
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 26, 2022
Fix inaccurate function name in `rustc_const_eval` docs

Looks to me like this fixes rust-lang#85513. I had trouble making a intra-docs link to `eval_place_to_op` work, though...
@bors
Copy link
Contributor

bors commented Mar 26, 2022

⌛ Testing commit 32b2a19 with merge 9fc29dd0768f3840f670bd323f94648cbc9ea279...

@bors
Copy link
Contributor

bors commented Mar 26, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2022
@rust-log-analyzer

This comment has been minimized.

@JohnCSimon
Copy link
Member

ping from triage:
@pierwill
Returning to you to address test failures

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022
@bors
Copy link
Contributor

bors commented Apr 28, 2022

☔ The latest upstream changes (presumably #95976) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 6, 2022
@pierwill
Copy link
Member Author

pierwill commented May 6, 2022

@rustbot ready

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 6, 2022
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2022
@apiraino
Copy link
Contributor

@JohnCSimon is further review neeeded or will this be automatically merged? another r+ rollup?

@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 11, 2022

📌 Commit f1f0734 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2022
Rollup of 4 pull requests

Successful merges:

 - rust-lang#91518 (Add readable rustdoc display for RISC-V target)
 - rust-lang#95281 (Fix inaccurate function name in `rustc_const_eval` docs)
 - rust-lang#96898 (logging: add env var to control verbose scope entry/exit logging)
 - rust-lang#96936 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0c2cee2 into rust-lang:master May 11, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slight inaccuracy in the rustc_mir documentation
7 participants