Rollup of 5 pull requests #95526
Merged
Rollup of 5 pull requests #95526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…box, r=estebank Specialize infinite-type "insert some indirection" suggestion for Option Suggest `Option<Box<_>>` instead of `Box<Option<_>>` for infinitely-recursive members of a struct. Not sure if I can get the span of the generic subty of the Option so I can make this a `+++`-style suggestion. The current output is a tiny bit less fancy looking than the original suggestion. Should I limit the specialization to just `Option<Box<TheOuterStruct>>`? Because right now it applies to all `Option` members in the struct that are returned by `Representability::SelfRecursive`. Fixes rust-lang#91402 r? `@estebank` (since you wrote the original suggestion and are definitely most familiar with it!)
…zed, r=Dylan-DPC Update target_has_atomic documentation for stabilization `cfg(target_has_atomic)` was stabilized in rust-lang#93824, but this small note in the docs was not updated at the time.
small rustc_borrowck cleanup r? `@jackh726` because of the second commit, seems like that comment was missed in rust-lang#91243
Fix typos in core::ptr docs
remove unused field from `infcx` r? `@oli-obk` did we stop needing that for opaque types?
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit 1074c81 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (0677edc): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
infcx#95523 (remove unused field frominfcx)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup