Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: do not compile libcore twice when performing LLVM PGO #95927

Merged
merged 1 commit into from
Apr 12, 2022
Merged

CI: do not compile libcore twice when performing LLVM PGO #95927

merged 1 commit into from
Apr 12, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 11, 2022

I forgot the delete the first compilation when modifying this file in a previous PR.

r? @lqd

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 11, 2022
@lqd
Copy link
Member

lqd commented Apr 11, 2022

Great, thanks for the cleanup!

This shouldn't any have performance impact and should be safe to rollup, but let's see.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 11, 2022
@bors
Copy link
Contributor

bors commented Apr 11, 2022

⌛ Trying commit aeb3df7 with merge 6891cb57bdf39cf22546fa319f647972cd9af80d...

@bors
Copy link
Contributor

bors commented Apr 11, 2022

☀️ Try build successful - checks-actions
Build commit: 6891cb57bdf39cf22546fa319f647972cd9af80d (6891cb57bdf39cf22546fa319f647972cd9af80d)

@rust-timer
Copy link
Collaborator

Queued 6891cb57bdf39cf22546fa319f647972cd9af80d with parent 48a9e10, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6891cb57bdf39cf22546fa319f647972cd9af80d): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 0 4 0
mean2 N/A N/A N/A -0.4% N/A
max N/A N/A N/A -0.4% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 11, 2022
@lqd
Copy link
Member

lqd commented Apr 11, 2022 •
edited
Loading

No perf changes as expected, so there shouldn't be any impact on CI (except for the few seconds it saves to compile libcore twice) and seems safe to rollup.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 11, 2022

📌 Commit aeb3df7 has been approved by lqd

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 11, 2022
@Dylan-DPC
Rollup merge of rust-lang#95927 - Kobzol:ci-pgo-libcore, r=lqd
ba25dc9 
CI: do not compile libcore twice when performing LLVM PGO

I forgot the delete the first compilation when modifying this file in a previous PR.

r? `@lqd`
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 11, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 11, 2022
@Dylan-DPC
Rollup merge of rust-lang#95927 - Kobzol:ci-pgo-libcore, r=lqd
633e004 
CI: do not compile libcore twice when performing LLVM PGO

I forgot the delete the first compilation when modifying this file in a previous PR.

r? ``@lqd``
This was referenced Apr 11, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2022
@bors
Auto merge of rust-lang#95944 - Dylan-DPC:rollup-idggkrh, r=Dylan-DPC
de392c7 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#95008 ([`let_chains`] Forbid `let` inside parentheses)
 - rust-lang#95801 (Replace RwLock by a futex based one on Linux)
 - rust-lang#95864 (Fix miscompilation of inline assembly with outputs in cases where we emit an invoke instead of call instruction.)
 - rust-lang#95894 (Fix formatting error in pin.rs docs)
 - rust-lang#95895 (Clarify str::from_utf8_unchecked's invariants)
 - rust-lang#95901 (Remove duplicate aliases for `check codegen_{cranelift,gcc}` and fix `build codegen_gcc`)
 - rust-lang#95927 (CI: do not compile libcore twice when performing LLVM PGO)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 070e8ed into rust-lang:master Apr 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 12, 2022
@Kobzol Kobzol deleted the ci-pgo-libcore branch April 12, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Kobzol @lqd @rust-timer @bors @rust-highfive @rustbot