Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library/core: Fixes implement of c_uint, c_long, c_ulong #96280

Merged
merged 2 commits into from
May 3, 2022
Merged

library/core: Fixes implement of c_uint, c_long, c_ulong #96280

merged 2 commits into from
May 3, 2022

Conversation

lygstate
Copy link
Contributor

Fixes: aa67016 ("make memcmp return a value of c_int_width instead of i32")
Introduce c_num_definition to getting the cfg_if logic easier to maintain
Add newlines for easier code reading

Signed-off-by: Yonggang Luo luoyonggang@gmail.com

@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 21, 2022
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2022
@lygstate
Copy link
Contributor Author

@drmorr0 @joshtriplett

@lygstate
Copy link
Contributor Author

@petrochenkov

@lygstate
library/core: Fixes implement of c_uint, c_long, c_ulong
1d5948f 
Fixes: aa67016 ("make memcmp return a value of c_int_width instead of i32")
Introduce c_num_definition to getting the cfg_if logic easier to maintain
Add newlines for easier code reading

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
@lygstate
Copy link
Contributor Author

@joshtriplett Ping for review

@lygstate
Copy link
Contributor Author

lygstate commented May 3, 2022

r? @joshtriplett

@joshtriplett
Copy link
Member

Seems reasonable. r=me with the comment nit addressed.

@lygstate @joshtriplett
Update library/core/src/ffi/mod.rs
2e69549 
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 3, 2022

📌 Commit 2e69549 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2022
@bors
Copy link
Contributor

bors commented May 3, 2022

⌛ Testing commit 2e69549 with merge 994b31fda2b3b08892294906546b4f4eb03c8d26...

@bors
Copy link
Contributor

bors commented May 3, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 3, 2022
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
To only update this specific test, also pass `--test-args block-doc-comment.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustdoc" "/checkout/src/test/rustdoc-ui/block-doc-comment.rs" "-Zthreads=1" "--target=aarch64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-o" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/rustdoc-ui/block-doc-comment" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--test" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/rustdoc-ui/block-doc-comment/auxiliary"
running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
------------------------------------------

@lygstate
Copy link
Contributor Author

lygstate commented May 3, 2022

I can not figure out what's happened

@petrochenkov
Copy link
Contributor

Spurious failure due to #93715 (comment).
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2022
@bors
Copy link
Contributor

bors commented May 3, 2022

⌛ Testing commit 2e69549 with merge 465bd39d6bdbba3c3057177529ed3c3dd8710448...

@bors
Copy link
Contributor

bors commented May 3, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 3, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......... (60/63)
...        (63/63)


/checkout/src/test/rustdoc-gui/docblock-table-overflow.goml An exception occured: socket hang up
== STACKTRACE ==
Error
    at innerRunTestCode (/node-v14.4.0-linux-x64/lib/node_modules/browser-ui-test/src/index.js:513:16)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async main (/checkout/src/tools/rustdoc-gui/tester.js:225:13)

@petrochenkov
Copy link
Contributor

Another spurious failure in rustdoc tests /checkout/src/test/rustdoc-gui/docblock-table-overflow.goml
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2022
@bors
Copy link
Contributor

bors commented May 3, 2022

⌛ Testing commit 2e69549 with merge 086bf7a...

@bors
Copy link
Contributor

bors commented May 3, 2022

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing 086bf7a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 3, 2022
@bors bors merged commit 086bf7a into rust-lang:master May 3, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 3, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (086bf7a): comparison url.

Summary:

  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 0 0 0 1
mean2 0.2% N/A N/A N/A 0.2%
max 0.2% N/A N/A N/A 0.2%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

@petrochenkov petrochenkov petrochenkov approved these changes

Assignees

@joshtriplett joshtriplett

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lygstate @rust-highfive @joshtriplett @bors @rust-log-analyzer @petrochenkov @rust-timer @rustbot