Add rustc_nonnull_optimization_guaranteed to Owned/Borrowed Fd/Socket #96947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR rust-lang#94586 added support for using `rustc_nonnull_optimization_guaranteed` on values where the "null" value is the all-ones bitpattern. Now that rust-lang#94586 has made it to the stage0 compiler, add `rustc_nonnull_optimization_guaranteed` to `OwnedFd`, `BorrowedFd`, `OwnedSocket`, and `BorrowedSocket`, since these types all exclude all-ones bitpatterns. This allows `Option<OwnedFd>`, `Option<BorrowedFd>`, `Option<OwnedSocket>`, and `Option<BorrowedSocket>` to be used in FFI declarations, as described in the [I/O safety RFC]. [I/O safety RFC]: https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md#ownedfd-and-borrowedfdfd-1
sunfishcode
added
the
T-libs-api
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
sunfishcode
added a commit
to sunfishcode/io-lifetimes
that referenced
this pull request
May 11, 2022
This ports in the new tests added in rust-lang/rust#96947.
sunfishcode
added a commit
to sunfishcode/io-lifetimes
that referenced
this pull request
May 11, 2022
This ports in the new tests added in rust-lang/rust#96947.
scottmcm
added
the
needs-fcp
|
@bors r+ |
|
📌 Commit 5c60951 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#96947 (Add rustc_nonnull_optimization_guaranteed to Owned/Borrowed Fd/Socket) - rust-lang#97021 (Added note in documentation) - rust-lang#97042 (Add new eslint rule about brace style) - rust-lang#97060 (Fix use of SetHandleInformation on UWP) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
sunfishcode
removed
the
needs-fcp
|
@scottmcm I removed the needs-fcp here; this PR only affects |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #94586 added support for using
rustc_nonnull_optimization_guaranteedon values where the "null" valueis the all-ones bitpattern.
Now that #94586 has made it to the stage0 compiler, add
rustc_nonnull_optimization_guaranteedtoOwnedFd,BorrowedFd,OwnedSocket, andBorrowedSocket, since these types all excludeall-ones bitpatterns.
This allows
Option<OwnedFd>,Option<BorrowedFd>,Option<OwnedSocket>,and
Option<BorrowedSocket>to be used in FFI declarations, as describedin the I/O safety RFC.