Allow to click on setting text #97317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
gui-settings-text-click
branch
from
ecb38c8
to
61d8176
Compare
|
Fixed the eslint error. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
gui-settings-text-click
branch
from
61d8176
to
39bdb04
Compare
|
The correct way to do this is not with an onclick handler, it's by putting the text inside a |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
gui-settings-text-click
branch
from
39bdb04
to
c8075f5
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
gui-settings-text-click
branch
from
c8075f5
to
f4f14f6
Compare
GuillaumeGomez
added
A-rustdoc-ui
|
@bors r+ rollup |
|
📌 Commit f4f14f6 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2022
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#97317 (Allow to click on setting text) - rust-lang#97375 (Simplify implementation of `-Z gcc-ld`) - rust-lang#97394 (Add more eslint rules) - rust-lang#97407 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 26, 2022
…te, r=notriddle Updates to browser-ui-test I took the commits from rust-lang#97317. Since the ubuntu 22.04 version, you either need to use `--no-sandbox` or use another binary to run the GUI tests. I couldn't find out why the chromium used by `browser-ui-test` isn't working anymore on this ubuntu version. r? `@notriddle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test it here.
This PR allows to click on the text alongside the toggle to change it.
r? @jsha