[CRATER] separate type equality from mutual subtyping

[lcnr]

cc #97156

[rust-highfive]

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

[lcnr]

r? @nikomatsakis

[lcnr]

@bors try

[bors]

⌛ Trying commit 1554eb1bbbb7d38be371ab397e11bf8c2fef49b2 with merge 54f7166aef449d83951621ef9cd9750293f42bbc...

[lcnr]

@bors retry

[bors]

⌛ Trying commit 1554eb1bbbb7d38be371ab397e11bf8c2fef49b2 with merge c1245a7f927a572455320a69e31499110394fd30...

[lcnr]

@bors try

[bors]

⌛ Trying commit 124673b with merge ba0adcb6607ec53c8b2f7626bcdbe21161b99c69...

[lcnr]

@bors try

[bors]

⌛ Trying commit de40841 with merge 4e3d7541a523df82cea75064e44e60ae9a008bcb...

[rust-log-analyzer]

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling tempfile v3.2.0
   Compiling serde_json v1.0.59
   Compiling lint-docs v0.1.0 (/checkout/src/tools/lint-docs)
    Finished release [optimized] target(s) in 6.06s
warning: the code example in lint `coherence_leak_check` in /checkout/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `coherence_leak_check` in output of example, got:

Rustbook (x86_64-unknown-linux-gnu) - rustc
Rustbook (x86_64-unknown-linux-gnu) - cargo
Rustbook (x86_64-unknown-linux-gnu) - embedded-book
---
doc tests for: /checkout/src/doc/rustc/src/tests/index.md
doc tests for: /checkout/src/doc/rustc/src/what-is-rustc.md
 finished in 1.246 seconds
Generating lint docs (x86_64-unknown-linux-gnu)
error: failed to test example in lint docs for `coherence_leak_check` in /checkout/compiler/rustc_lint_defs/src/builtin.rs:1433: did not find lint `coherence_leak_check` in output of example, got:


This error was generated by the lint-docs tool.
This error was generated by the lint-docs tool.
This tool extracts documentation for lints from the source code and places
them in the rustc book. See the declare_lint! documentation
https://doc.rust-lang.org/nightly/nightly-rustc/rustc_lint_defs/macro.declare_lint.html


To re-run these tests, run: ./x.py test --keep-stage=0 src/tools/lint-docs
The --keep-stage flag should be used if you have already built the compiler
Build completed unsuccessfully in 0:31:56

[bors]

☀️ Try build successful - checks-actions
Build commit: 4e3d7541a523df82cea75064e44e60ae9a008bcb (4e3d7541a523df82cea75064e44e60ae9a008bcb)

[lcnr]

@craterbot check 4e3d7541a523df82cea75064e44e60ae9a008bcb

[craterbot]

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[lcnr]

@craterbot check

[craterbot]

👌 Experiment pr-97427 created and queued.
🤖 Automatically detected try build 4e3d7541a523df82cea75064e44e60ae9a008bcb
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[RalfJung]

bidirectional subtyping

A note on terminology: "bidirectional typing" is a thing and it has nothing to do with what you do here, so to people like me your terminology is very confusing. :) I would recommend something like "mutual subtyping", or "symmetric closure of subtyping".

[craterbot]

🚧 Experiment pr-97427 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-97427 is completed!
📊 25 regressed and 9 fixed (236156 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[Mark-Simulacrum]

Closing as crate results are available whenever needed, but this PR otherwise doesn't serve any purpose.