Rollup of 5 pull requests

[matthiaskrgr]

Successful merges:

• Make hir().get_generics and generics_of consistent. #97446 (Make hir().get_generics and generics_of consistent.)
• Add a suggestion to replace parentheses with angle brackets on associated trait constraint #97656 (Add a suggestion to replace parentheses with angle brackets on associated trait constraint)
• Add #T-types/nominated zulip notification #97692 (Add #T-types/nominated zulip notification)
• Do not ICE when failing to normalize during inlining. #97696 (Do not ICE when failing to normalize during inlining.)
• Remove useless LocalDefId in ImplTraitContext::Universal. #97702 (Remove useless LocalDefId in ImplTraitContext::Universal.)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit a88d94b has been approved by matthiaskrgr

[bors]

⌛ Testing commit a88d94b with merge 8510fc81255f508737f40d09887aa7f495c2dd3b...

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

wut...

Running 64 rustdoc-gui (16 concurrently) ...
.......... (10/64)
.......... (20/64)
.......... (30/64)
.......... (40/64)
.......... (50/64)
.......... (60/64)
...       (64/64)
/checkout/src/test/rustdoc-gui/search-tab-change-title-fn-sig.goml search-tab-change-title-fn-sig... FAILED
Error:  (line 6) Error: The following CSS selector "#titles" was not found: for command `wait-for: "#titles"`

[matthiaskrgr]

@bors retry ? 🙃

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.......... (60/64)
...       (64/64)


/checkout/src/test/rustdoc-gui/search-tab-change-title-fn-sig.goml search-tab-change-title-fn-sig... FAILED
[ERROR] (line 6) Error: The following CSS selector "#titles" was not found: for command `wait-for: "#titles"`
Build completed unsuccessfully in 0:00:42

[bors]

⌛ Testing commit a88d94b with merge c3384ea...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing c3384ea to master...

[rust-timer]

Finished benchmarking commit (c3384ea): comparison url.

Instruction count

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions 😿 (primary)	0.3%	0.3%	6
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.3%	0.3%	6

Max RSS (memory usage)

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions 😿 (primary)	1.7%	1.7%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-3.4%	-3.4%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.9%	-3.4%	2

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[rylev]

This might be caused by some variability in the Diesel benchmark. While the regressions are not clearly due to this variability, we've had several rollups that seemed to have been impacted by this. This regression is only in Diesel and the regressions are quite small. It's not worth it to look into this any more.

@rustbot label: +perf-regression-triaged