Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostics: remove trailing spaces #97892

Merged
merged 5 commits into from
Jun 17, 2022
Merged

diagnostics: remove trailing spaces #97892

merged 5 commits into from
Jun 17, 2022

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jun 8, 2022

Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 8, 2022
@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 12, 2022

☔ The latest upstream changes (presumably #97778) made this pull request unmergeable. Please resolve the merge conflicts.

@klensy klensy force-pushed the fix-spaces branch 2 times, most recently from 62f2eea to fbb6636 Compare June 12, 2022 06:59
@oli-obk
Copy link
Contributor

oli-obk commented Jun 13, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jun 13, 2022

📌 Commit fbb6636 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 13, 2022
@Dylan-DPC
Rollup merge of rust-lang#97892 - klensy:fix-spaces, r=oli-obk
17212dd 
diagnostics: remove trailing spaces

Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 13, 2022
Closed
@Dylan-DPC
Copy link
Member

@bors r=iffy

@bors
Copy link
Contributor

bors commented Jun 14, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jun 14, 2022

📌 Commit fbb6636 has been approved by iffy

@Dylan-DPC
Copy link
Member

lol

@bors rollup=iffy

@Dylan-DPC
Copy link
Member

bors r=oli-obk

@Dylan-DPC
Copy link
Member

@bors r=oli-obk

(sorry for the noise :P)

@bors
Copy link
Contributor

bors commented Jun 14, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Jun 14, 2022

📌 Commit fbb6636 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Jun 14, 2022

⌛ Testing commit fbb6636 with merge 058e0ebdb3b3ac083cd77fa7f32893862fdc9656...

@bors
Copy link
Contributor

bors commented Jun 14, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 14, 2022
@klensy
Copy link
Contributor Author

klensy commented Jun 15, 2022 •
edited
Loading

blessed clippy tests, hope no more left.

@Dylan-DPC
Copy link
Member

@bors r=oli-obk

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@klensy
Copy link
Contributor Author

klensy commented Jun 16, 2022

Rebased. Tests rot quite fast, sadly.

@Dylan-DPC
Copy link
Member

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jun 16, 2022

📌 Commit 6fc412f has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2022
@bors
Copy link
Contributor

bors commented Jun 16, 2022

⌛ Testing commit 6fc412f with merge ebdd693854f9118a54e4ee9fdad778cbc7d8e099...

@klensy
Copy link
Contributor Author

klensy commented Jun 16, 2022

job auto (i686-gnu-nopt, ubuntu-20.04-xl): looks like it hangs.

@bors
Copy link
Contributor

bors commented Jun 16, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 16, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Dylan-DPC
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2022
@bors
Copy link
Contributor

bors commented Jun 17, 2022

⌛ Testing commit 6fc412f with merge 0cb9899...

@bors
Copy link
Contributor

bors commented Jun 17, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 0cb9899 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 17, 2022
@bors bors merged commit 0cb9899 into rust-lang:master Jun 17, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 17, 2022
@bors bors mentioned this pull request Jun 17, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0cb9899): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.9% -2.9% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 2.7% 2.7% 1
Regressions 😿
(secondary)		 2.0% 2.0% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.7% 2.7% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2022
@bors
Auto merge of rust-lang#97892 - klensy:fix-spaces, r=oli-obk
09c9301 
diagnostics: remove trailing spaces

Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
8 participants
@klensy @rust-highfive @rust-log-analyzer @bors @oli-obk @Dylan-DPC @rust-timer @rustbot