[RFC 2011] Expand expressions where possible

[c410-f3r]

Tracking issue: #44838
Fourth step of #96496

Extends #97665 considering expressions that are good candidates for expansion.

r? @oli-obk

[oli-obk]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 47b057a with merge 025f1f8efa4f860a51b24ee27c3b76f84d254bde...

[bors]

☀️ Try build successful - checks-actions
Build commit: 025f1f8efa4f860a51b24ee27c3b76f84d254bde (025f1f8efa4f860a51b24ee27c3b76f84d254bde)

[rust-timer]

Queued 025f1f8efa4f860a51b24ee27c3b76f84d254bde with parent 6ec3993, future comparison URL.

[rust-timer]

Finished benchmarking commit (025f1f8efa4f860a51b24ee27c3b76f84d254bde): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.7%	-0.7%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.7%	-0.7%	1

Cycles

Results

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	2.9%	2.9%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.1%	-2.1%	1
All 😿🎉 (primary)	2.9%	2.9%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[oli-obk]

@bors r+

[bors]

📌 Commit 47b057a has been approved by oli-obk

[bors]

⌛ Testing commit 47b057a with merge 42dcf70...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 42dcf70 to master...

[rust-timer]

Finished benchmarking commit (42dcf70): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.3%	-0.4%	2
Improvements 🎉 (secondary)	-0.7%	-0.8%	6
All 😿🎉 (primary)	-0.3%	-0.4%	2

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.0%	-4.6%	3
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.3%	2.3%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[c410-f3r]

This PR, as well as some other PRS, shows that Perf is acting stochastically.