Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give name if anonymous region appears in impl signature #98184

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Give name if anonymous region appears in impl signature #98184

merged 1 commit into from
Jun 24, 2022

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jun 17, 2022 •
edited
Loading

Fixes #98170

We probably should remove the two unwraps in report_general_error, but I have no idea what to provide if those regions are missing, so I've kept those in. Let me know if I should try harder to remove those.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 17, 2022
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2022
cjgillot
cjgillot reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @compiler-errors. I have an issue with the the impl_parent query. reusing the query to do something else may be confusing.

compiler/rustc_middle/src/hir/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/hir/map/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/hir/map/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_borrowck/src/diagnostics/region_name.rs Show resolved Hide resolved
src/test/ui/nll/issue-98170.rs Show resolved Hide resolved
@compiler-errors
Copy link
Member Author

compiler-errors commented Jun 17, 2022 •
edited
Loading

@cjgillot oh is it? that's embarrassing, I misunderstood its purpose. Yeah, I can do this by just looking at hir directly.

edit: oh, I saw you provided a query that avoids looking at hir too, cool.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2022
@lcnr
Copy link
Contributor

lcnr commented Jun 20, 2022

r? @cjgillot maybe, considering that you've already reviewed this pr

skimming over this pr it looks alright 👍

@rust-highfive rust-highfive assigned cjgillot and unassigned lcnr Jun 20, 2022
@compiler-errors compiler-errors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2022
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 21, 2022

📌 Commit e900a35 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#98184 - compiler-errors:elided-lifetime-in-…
65a6164 
…impl-nll, r=cjgillot

Give name if anonymous region appears in impl signature

Fixes rust-lang#98170

We probably should remove the two unwraps in [`report_general_error`](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_borrowck/diagnostics/region_errors.rs.html#683-685), but I have no idea what to provide if those regions are missing, so I've kept those in. Let me know if I should try harder to remove those.
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 21, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#98184 - compiler-errors:elided-lifetime-in-…
b5a2a80 
…impl-nll, r=cjgillot

Give name if anonymous region appears in impl signature

Fixes rust-lang#98170

We probably should remove the two unwraps in [`report_general_error`](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_borrowck/diagnostics/region_errors.rs.html#683-685), but I have no idea what to provide if those regions are missing, so I've kept those in. Let me know if I should try harder to remove those.
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 21, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 22, 2022
@Dylan-DPC
Rollup merge of rust-lang#98184 - compiler-errors:elided-lifetime-in-…
c26b9dd 
…impl-nll, r=cjgillot

Give name if anonymous region appears in impl signature

Fixes rust-lang#98170

We probably should remove the two unwraps in [`report_general_error`](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_borrowck/diagnostics/region_errors.rs.html#683-685), but I have no idea what to provide if those regions are missing, so I've kept those in. Let me know if I should try harder to remove those.
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 22, 2022
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 23, 2022
@compiler-errors
Rollup merge of rust-lang#98184 - compiler-errors:elided-lifetime-in-…
0ab8a66 
…impl-nll, r=cjgillot

Give name if anonymous region appears in impl signature

Fixes rust-lang#98170

We probably should remove the two unwraps in [`report_general_error`](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_borrowck/diagnostics/region_errors.rs.html#683-685), but I have no idea what to provide if those regions are missing, so I've kept those in. Let me know if I should try harder to remove those.
@compiler-errors compiler-errors mentioned this pull request Jun 23, 2022
Closed
@compiler-errors compiler-errors mentioned this pull request Jun 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 24, 2022
@bors
Auto merge of rust-lang#98438 - compiler-errors:rollup-fudubjn, r=com…
e605a88 
…piler-errors

Rollup of 16 pull requests

Successful merges:

 - rust-lang#96173 (Fix documentation for  `with_capacity` and `reserve` families of methods)
 - rust-lang#98184 (Give name if anonymous region appears in impl signature)
 - rust-lang#98259 (Greatly improve error reporting for futures and generators in `note_obligation_cause_code`)
 - rust-lang#98269 (Provide a `PathSegment.res` in more cases)
 - rust-lang#98283 (Point at private fields in struct literal)
 - rust-lang#98305 (prohibit_generics: don't alloc error string if no error emitted)
 - rust-lang#98310 (rustdoc: optimize loading of source sidebar)
 - rust-lang#98353 (Migrate two diagnostics from the `rustc_builtin_macros` crate)
 - rust-lang#98355 (Update no_default_libraries handling for emscripten target)
 - rust-lang#98364 (clarify Arc::clone overflow check comment)
 - rust-lang#98365 (Address review comments from rust-lang#98259)
 - rust-lang#98388 (implement `iter_projections` function on `PlaceRef`)
 - rust-lang#98390 (Fixes handling of keywords in rustdoc json output)
 - rust-lang#98409 (triagebot.toml: Allow applying nominated labels)
 - rust-lang#98410 (Update books)
 - rust-lang#98422 (Update browser-ui-test version to 0.9.6)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 49bcc70 into rust-lang:master Jun 24, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 24, 2022
@compiler-errors compiler-errors deleted the elided-lifetime-in-impl-nll branch August 11, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

rustc panic
6 participants
@compiler-errors @rust-highfive @lcnr @cjgillot @bors @rustbot