Make some clean::Trait fields computation on demand

[GuillaumeGomez]

r? @notriddle

[rustbot]

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

[GuillaumeGomez]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit edb9add with merge 9cf9c1165517fc1279f15f86fa4e2364e0e52e8a...

[bors]

☀️ Try build successful - checks-actions
Build commit: 9cf9c1165517fc1279f15f86fa4e2364e0e52e8a (9cf9c1165517fc1279f15f86fa4e2364e0e52e8a)

[rust-timer]

Queued 9cf9c1165517fc1279f15f86fa4e2364e0e52e8a with parent e7a9c11, future comparison URL.

[notriddle]

r=me if it's not a perf regression

[rust-timer]

Finished benchmarking commit (9cf9c1165517fc1279f15f86fa4e2364e0e52e8a): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-3.9%	-4.3%	2
Improvements 🎉 (secondary)	-2.6%	-3.1%	5
All 😿🎉 (primary)	-3.9%	-4.3%	2

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvement found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.3%	-2.3%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[notriddle]

@bors r+

[bors]

📌 Commit edb9add has been approved by notriddle

It is now in the queue for this repository.

[bors]

⌛ Testing commit edb9add with merge ffa7733...

[bors]

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing ffa7733 to master...

[rust-timer]

Finished benchmarking commit (ffa7733): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	3.1%	3.1%	1
Regressions 😿 (secondary)	4.4%	5.9%	2
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	3.1%	3.1%	1

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.1%	3.1%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²