Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some is_useful cleanups #99843

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Some is_useful cleanups #99843

merged 3 commits into from
Aug 4, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 28, 2022 •
edited
Loading

#98582 was reverted because it was a perf regression.

#99806 reintroduces the changes, but this PR picks individual ones that have no regressions.

@rust-highfive
Copy link
Collaborator

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 28, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 28, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 28, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 28, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jul 28, 2022

⌛ Trying commit 803d374 with merge e0e5c4167a997e7deaefcaa43e0976e8736f3fc4...

@oli-obk

This comment was marked as resolved.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 28, 2022

☀️ Try build successful - checks-actions
Build commit: e0e5c4167a997e7deaefcaa43e0976e8736f3fc4 (e0e5c4167a997e7deaefcaa43e0976e8736f3fc4)

@rust-timer
Copy link
Collaborator

Queued e0e5c4167a997e7deaefcaa43e0976e8736f3fc4 with parent 48316df, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e0e5c4167a997e7deaefcaa43e0976e8736f3fc4): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.2% -2.2% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 3.0% 3.0% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.1% -2.2% 2
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -0.4% 3.0% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 28, 2022
@oli-obk oli-obk closed this Jul 28, 2022
@oli-obk oli-obk deleted the is_useful_perf branch July 28, 2022 13:06
@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 28, 2022

yay, using references is the way to go

@oli-obk oli-obk changed the title WIP: Pick components of #98582 to see where the perf regression is at Some is_useful cleanups Jul 29, 2022
@oli-obk oli-obk restored the is_useful_perf branch July 29, 2022 15:08
@oli-obk oli-obk reopened this Jul 29, 2022
@oli-obk oli-obk marked this pull request as ready for review July 29, 2022 15:09
@compiler-errors
Copy link
Member

compiler-errors commented Aug 3, 2022 •
edited
Loading

❤️

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2022

📌 Commit 803d374 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 3, 2022
@bors
Copy link
Contributor

bors commented Aug 4, 2022

⌛ Testing commit 803d374 with merge 2f2243c...

@bors
Copy link
Contributor

bors commented Aug 4, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 2f2243c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 4, 2022
@bors bors merged commit 2f2243c into rust-lang:master Aug 4, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 4, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2f2243c): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 1.1% 1.1% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.2% 3.2% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.6% -2.6% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.5% 2.5% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.5% -3.5% 1
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-highfive @rust-timer @bors @compiler-errors @rustbot