Apply the recursion limit to the parser instead of just to the printer. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you'd like me to move the tests in |
pcwalton
force-pushed
the
parse-limit
branch
2 times, most recently
from
231371a
to
74dccc6
Compare
|
Fuzzing found a few more stack overflows. Let me fix them before merging this. |
|
Oh dear, thanks for this though! I'm happy to merge when you feel this is ready, though |
Raphael Salas found more stack overflows involving very large symbols that failed while the parser was trying to skip over tokens. These are fixed by moving the recursion limiter from the printer to the parser, and updating the printer to use the parser's limiter. The failing cases are added as unit tests.
pcwalton
changed the title
|
Didn't find any more fuzz bugs. I think this is good to go. |
|
Thanks! |
eddyb
reviewed
Jul 18, 2021
eddyb
reviewed
Jul 20, 2021
This was referenced Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raphael Salas found more stack overflows involving very large symbols that
failed while the parser was trying to skip over tokens. These are fixed by
moving the recursion limiter from the printer to the parser, and updating the
printer to use the parser's limiter.
The failing cases are added as unit tests.
I'm submitting this for review while I run the fuzzer overnight.
r? @alexcrichton