rustfmt 1.x bump rustc-ap to v642 #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport the fix for the parser bug where the messages from fatal/non-recoverable parser errors were being silently eaten by rustfmt.
This was referenced Feb 9, 2020
calebcartwright
commented
Feb 9, 2020
|
@calebcartwright Thank you for your work! I was about to ask whether you could make a pull request that backports the #4022 to the rustfmt-1.4.11 branch, but then I found out that you have already created the PR! Thanks a million. I changed the base branch to rustfmt-1.4.12, which is based on rustfmt-1.4.11, to keep the branch in the correct state. |
This was referenced Feb 10, 2020
|
@topecongiro when you get a chance can you publish v1.4.12 to crates.io? I've gotten Racer bumped to rustc-ap-* v642 as well (racer-rust/racer#1091), and IIUC once v1.4.12 is published I can open a PR to update Rls so that Rls and rustfmt can then be fixed and available again on nightlies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the rustc-ap deps to v642 for the latest 1.x version of rustfmt
Refs rust-lang/rust#68917
Resolves #3903
Resolves #4009