Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass --locked when installing rustfmt in integration tests #5385

Merged

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Jun 13, 2022

There was recently an issue where cargo install was installing a newer version of a dependency than the one listed in our Cargo.toml. The newer version added deprecation warnings that caused our continuous integration tests to break.

As mentioned in the cargo help install docs, passing the --locked flag should force cargo to use the Cargo.lock file included with the repository.

ref: #5384 (comment)

There was recently an issue where `cargo install` was installing a newer
version of a dependency than the one listed in our Cargo.toml. The newer
version added deprecation warnings that caused our continuous integration
tests to break.

As mentioned in the `cargo help install` docs, passing the `--locked`
flag should force cargo to use the `Cargo.lock` file included with
the repository.
@ytmimi
Copy link
Contributor Author

ytmimi commented Jun 13, 2022

Also noticing that this would backport #3889, which looked to solve a similar issue when cargo was pulling in a newer version of crossbeam-channel.

@ytmimi ytmimi force-pushed the use-cargo-lock-in-integration-tests branch from 8371f29 to 1ccbc1c Compare June 13, 2022 17:33
@calebcartwright
Copy link
Member

This is fine and I will merge, but waiting to make sure bors will accept the upstream sync PR in order to avoid any complexity around git tags and releases

@ytmimi
Copy link
Contributor Author

ytmimi commented Jun 14, 2022

Great 😁 I also figured it would be best to wait on the upstream sync. No rush though!

@calebcartwright calebcartwright merged commit 1a6146e into rust-lang:master Jun 14, 2022
@ytmimi ytmimi deleted the use-cargo-lock-in-integration-tests branch August 7, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants