Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust-analyzer proxy #2408

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Add rust-analyzer proxy #2408

merged 2 commits into from
Jul 9, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 9, 2020

No description provided.

matklad and others added 2 commits July 9, 2020 13:40
@matklad
Add rust-analyzer proxy
6e7918e
@kinnison
snap: Add rust-analyzer to snapcraft proxy list
9d3844f 
For this to be complete, we must request the proxy to be supported
in the snapcraft store.  This should be done after merging this
to master but before making a new release if we want it to
propagate properly.

Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
@kinnison
Copy link
Contributor

kinnison commented Jul 9, 2020

I've added the proxy to the snapcraft bit too, I forgot to mention that earlier on discord.

@kinnison kinnison merged commit 721ef45 into rust-lang:master Jul 9, 2020
@kinnison kinnison mentioned this pull request Jul 10, 2020
Closed
@akurtakov
Copy link

Is this change visible for users on nightly channel?

@rbtcollins
Copy link
Contributor

We need to cut a release before this will become visible to rustup users.

@akurtakov
Copy link

Any hope for new release?

@kinnison
Copy link
Contributor

I'm afraid with everything going on in the world, I've been too busy to cut a release. I'll be looking to do so in the near future though.

@akurtakov akurtakov mentioned this pull request Nov 17, 2020
Closed
@akurtakov
Copy link

Too bad this one didn't make it to 1.23.0 release.

@kinnison
Copy link
Contributor

This was explicitly backed out for 1.23.0 because rust-analyzer isn't going to be in stable for a while.

@akurtakov
Copy link

So there is not a chance to have the proxy for nightly only for now?

@kinnison
Copy link
Contributor

Proxies are installed into PATH so it's not possible to only provide a proxy for one toolchain, no. When we have a closer timeline for the component making it to stable we'll put the proxy back in.

@kinnison
Copy link
Contributor

You can make the link yourself, and then rust-analyzer +nightly ought to work; but it's not ideal.

@ehuss ehuss mentioned this pull request May 31, 2022
Closed
@ehuss ehuss mentioned this pull request Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matklad @kinnison @akurtakov @rbtcollins