[RFC] Add support for receiving ancillary data #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new methods are added in order to receive ancillary data along with normal data. The methods are `recv_with_ancillary_data` and `recv_vectored_with_ancillary_data_and_flags`. The former is easier to use, while the latter provides the flexibility. The implementation includes changes to the `recvmsg` function in the `sys/unix.rs` file to handle the ancillary data. A new test case is also added to test the `recv_with_ancillary_data` method. Signed-off-by: yuguorui <yuguorui@pku.edu.cn>
| @@ -950,7 +950,18 @@ pub(crate) fn recv_vectored( | |||
| bufs: &mut [crate::MaybeUninitSlice<'_>], | |||
| flags: c_int, | |||
| ) -> io::Result<(usize, RecvFlags)> { | |||
| recvmsg(fd, ptr::null_mut(), bufs, flags).map(|(n, _, recv_flags)| (n, recv_flags)) | |||
| recvmsg(fd, ptr::null_mut(), bufs, &mut [], flags).map(|(n, _, recv_flags)| (n, recv_flags)) | |||
There was a problem hiding this comment.
I think the addition of &mut [] will be invalid as the pointer will be non-null.
|
Ok, no problem. I've been trying to find some workrounds for recvmsg on Windows, but unfortunately haven't found any continuous free time this week. Thanks again for your quick response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new methods are added in order to receive ancillary data along with normal data. The methods are
recv_with_ancillary_dataandrecv_vectored_with_ancillary_data_and_flags. The former is easier to use, while the latter provides the flexibility.The implementation includes changes to the
recvmsgfunction in thesys/unix.rsfile to handle the ancillary data.A new test case is also added to test the
recv_with_ancillary_datamethod.Known issue: windows support is broken.