Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error with target_env=ohos #491

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Chilledheart
Copy link
Contributor

OpenHarmony(alias ohos) is tie 3 supported target for rust. see rust-lang/compiler-team#568.

In implementation it sits close to musl instead of bionic and napi instead jni when comparing with android.

Below is copied from ohos sdk:

> ag iov_max openharmony/9/native/sysroot/usr/include
openharmony/9/native/sysroot/usr/include/limits.h
50:#define IOV_MAX 1024
162:#define _XOPEN_IOV_MAX          16

openharmony/9/native/sysroot/usr/include/unistd.h
320:#define _SC_IOV_MAX 60

OpenHarmony(alias ohos) is tie 3 supported target for rust.
see rust-lang/compiler-team#568.

In implementation it sits close to musl instead of bionic
and napi instead jni when comparing with android.

Below is copied from ohos sdk:

```
> ag iov_max openharmony/9/native/sysroot/usr/include
openharmony/9/native/sysroot/usr/include/limits.h
50:#define IOV_MAX 1024
162:#define _XOPEN_IOV_MAX          16

openharmony/9/native/sysroot/usr/include/unistd.h
320:#define _SC_IOV_MAX 60
```
@Chilledheart Chilledheart changed the title Fix compilation with target_env=ohos Fix compilation error with target_env=ohos Jan 28, 2024
@Thomasdezeeuw Thomasdezeeuw merged commit d11936f into rust-lang:master Jan 28, 2024
38 of 41 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @Chilledheart

@ldm0 ldm0 mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants