Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku: no SOCK_RDM support in Haiku #77

Merged
merged 1 commit into from
May 7, 2020

Conversation

nielx
Copy link
Contributor

@nielx nielx commented May 2, 2020

Do not add SOCK_RDM when compiling for Haiku.

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't know anything about Haiku.

@ghost
Copy link

ghost commented May 3, 2020

I don't know anything about Haiku either. Also okay with merging this PR, but it would be a good idea to do cargo check for haiku (and other platforms) in CI.

@Thomasdezeeuw
Copy link
Collaborator

I'm going to merge this, but I agree with @stjepang we should add more CI check tests so I've opened: #78.

@Thomasdezeeuw Thomasdezeeuw merged commit 43b75d3 into rust-lang:master May 7, 2020
@Thomasdezeeuw
Copy link
Collaborator

Thanks @nielx

nielx added a commit to nielx/rust that referenced this pull request Jun 3, 2020
nielx added a commit to nielx/rust that referenced this pull request Jul 26, 2020
nielx added a commit to nielx/rust that referenced this pull request Aug 28, 2020
nielx added a commit to nielx/rust that referenced this pull request Oct 16, 2020
@nielx nielx deleted the fix/SOCK_RDM branch October 17, 2020 10:47
nielx added a commit to nielx/rust that referenced this pull request Nov 18, 2020
nielx added a commit to nielx/rust that referenced this pull request Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants