Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The feature i8mm is not valid #1233

Closed
SparrowLii opened this issue Oct 18, 2021 · 2 comments · Fixed by #1250
Closed

The feature i8mm is not valid #1233

SparrowLii opened this issue Oct 18, 2021 · 2 comments · Fixed by #1250

Comments

@SparrowLii
Copy link
Member

SparrowLii commented Oct 18, 2021 •
edited
Loading

Currently std_detect implements i8mm feature on aarch64: here
But this feature does not seem to be available: https://rust.godbolt.org/z/8GbKW5ef4.
This led to the vmmla and vusmmla instructions not being implemented. As in #1230
@Amanieu
Copy link
Member

Amanieu commented Oct 19, 2021

I think this just needs to be added to the list in rustc, it's already supported by LLVM.

@Amanieu
Copy link
Member

Amanieu commented Oct 19, 2021

Looking at compiler/rustc_codegen_ssa/src/target_features.rs, it seems that it's just commented out. I think the reason is that at the time this list was updated we were still on LLVM 12 which didn't support this feature. It should be safe to uncomment now.

@SparrowLii SparrowLii mentioned this issue Oct 20, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 25, 2021
@GuillaumeGomez
Rollup merge of rust-lang#90079 - SparrowLii:i8mm, r=Amanieu
fec654e 
enable `i8mm` target feature on aarch64 and arm

As in rust-lang/stdarch#1233, `i8mm` needs to be turned on to support the implementation of `vmmla` and `vusmmla`neon instructions in stdarch.
r? `@Amanieu`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 25, 2021
@GuillaumeGomez
Rollup merge of rust-lang#90079 - SparrowLii:i8mm, r=Amanieu
bd48b99 
enable `i8mm` target feature on aarch64 and arm

As in rust-lang/stdarch#1233, `i8mm` needs to be turned on to support the implementation of `vmmla` and `vusmmla`neon instructions in stdarch.
r? ``@Amanieu``
@SparrowLii SparrowLii mentioned this issue Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add remaining insturctions SparrowLii/stdarch
2 participants
@Amanieu @SparrowLii