Convert SSE 4.2 intrinsics to const generics #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise intrinsics using, for example, "const int" parameters cannot be migrated to `#[rustc_legacy_const_generics]`
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the SSE 4.2 intrinsics :
_mm_cmpestra_mm_cmpestro_mm_cmpestrs_mm_cmpestrc_mm_cmpestrz_mm_cmpestri_mm_cmpestrm_mm_cmpistra_mm_cmpistro_mm_cmpistrs_mm_cmpistrc_mm_cmpistrz_mm_cmpistri_mm_cmpistrmto
rustc_legacy_const_genericsOf note, these intrinsics use "const int" parameters, and I believe the intrinsic verification is currently incomplete here: the first commit ensures the verifier also checks this new list of required consts. I'm unfamiliar with the verifier, so I may be missing something here.