Make SIMD tracking issue marked for stdsimd too
#460
Conversation
| @@ -11,7 +11,7 @@ mod ppsv; | |||
| /// This is an **unstable** module for portable SIMD operations. This module | |||
| /// has not yet gone through an RFC and is likely to change, but feedback is | |||
| /// always welcome! | |||
| #[unstable(feature = "stdsimd", issue = "0")] | |||
| #[unstable(feature = "stdsimd", issue = "27731")] | |||
There was a problem hiding this comment.
I think the issue is the right one, but maybe the feature should be core_simd ?
There was a problem hiding this comment.
I don't know if that feature already exists in rustc.
There was a problem hiding this comment.
ripgrep says there is no instance of core_simd or coresimd being a feature attribute in the rust repo + submodules.
| @@ -76,7 +76,7 @@ pub mod arch { | |||
| /// See the [module documentation](../index.html) for more details. | |||
| #[cfg(any(target_arch = "arm", dox))] | |||
| #[doc(cfg(target_arch = "arm"))] | |||
| #[unstable(feature = "stdsimd", issue = "0")] | |||
| #[unstable(feature = "stdsimd", issue = "27731")] | |||
There was a problem hiding this comment.
The feature we should use here is arm_target_feature, which already exists in rustc, but doesn't have a tracking issue there. There is a tracking issue in the stdsimd repo (#148) so maybe we should open one issue in the rust-lang/rust repo that forward users there and "block it from comments" ?
There was a problem hiding this comment.
@alexcrichton the alternative here is to add a new feature to rustc, arm_arch ?
There was a problem hiding this comment.
arm_target_feature is a language feature, not a library feature. I don’t know if the same name can be used for both.
There was a problem hiding this comment.
The library component is arch::arm (part of the std::arch` rfc), so maybe we just need new features for this :/
| @@ -86,7 +86,7 @@ pub mod arch { | |||
| /// See the [module documentation](../index.html) for more details. | |||
| #[cfg(any(target_arch = "aarch64", dox))] | |||
| #[doc(cfg(target_arch = "aarch64"))] | |||
| #[unstable(feature = "stdsimd", issue = "0")] | |||
| #[unstable(feature = "stdsimd", issue = "27731")] | |||
There was a problem hiding this comment.
The feature name that we could re-use is aarch64_target_feature, the alternative would be to add a new feature to rustc here (aarch64_arch?)
There was a problem hiding this comment.
The tracking issue here should probably be the same as the arm issue: #148 .
| @@ -106,7 +106,7 @@ pub mod arch { | |||
| /// See the [module documentation](../index.html) for more details. | |||
| #[cfg(any(target_arch = "mips", dox))] | |||
| #[doc(cfg(target_arch = "mips"))] | |||
| #[unstable(feature = "stdsimd", issue = "0")] | |||
| #[unstable(feature = "stdsimd", issue = "27731")] | |||
There was a problem hiding this comment.
Tracking issue here is #170 .
| @@ -116,7 +116,7 @@ pub mod arch { | |||
| /// See the [module documentation](../index.html) for more details. | |||
| #[cfg(any(target_arch = "mips64", dox))] | |||
| #[doc(cfg(target_arch = "mips64"))] | |||
| #[unstable(feature = "stdsimd", issue = "0")] | |||
| #[unstable(feature = "stdsimd", issue = "27731")] | |||
There was a problem hiding this comment.
Tracking issue here is #170 .
|
This is a drive-by PR that I’d rather keep minimal. Would you accept this as an incremental improvement without the feature name tweaking? |
| @@ -126,7 +126,7 @@ pub mod arch { | |||
| /// See the [module documentation](../index.html) for more details. | |||
| #[cfg(any(target_arch = "powerpc", dox))] | |||
| #[doc(cfg(target_arch = "powerpc"))] | |||
| #[unstable(feature = "stdsimd", issue = "0")] | |||
| #[unstable(feature = "stdsimd", issue = "27731")] | |||
There was a problem hiding this comment.
For powerpc we don't have a tracking issue in the stdsimd repo but there is one issue open about altivec in the rust-lang/rust repo that we might want to recycle here: rust-lang/rust#42743 cc @lu-zero I don't know if you wanted to open an issue in the stdsimd repo tracking powerpc status like we did for x86, arm, and msa, but if you do don't forget to cross-link that rust-lang/rust issue.
There was a problem hiding this comment.
I can open an issue about this as well. Do you have a specific format for the tracker ?
There was a problem hiding this comment.
No specific format, what I've done in the past is hack a script that just translate the vendor C API to rust types, and then formats it as a list for the tracker. Each vendor is different, so there is not much to reuse here :/
|
@SimonSapin I'll merge it as is, I'll just wanted to ping the relevant people to discuss what to do here, if anything at all. We already had one PR tuning this a couple of days ago. |
|
I've opened #461 to track the feature names. |
rust-lang/rust#27731