Add ARM Neon vmvn_*/vmvnq_* bitwise not intrinsics #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to contribute to #148 by adding a family of ARM Neon intrinsics. I started with the
vmvn_{s,u}*
/vmvnq_{s,u}*
family of intrinsics, which are all included in this PR, including tests.I just found out that there are also the
vmvn_p8
andvmvnq_p8
"poly" intrinsics which I did not yet implement. I would most likely want to add them as well before this PR should be merged. But, as this is my first contribution to the Rust standard libraries, I wanted to ask for comments/review first before continuing. So please let me know, if anything could/should be done different/better.This has been tested locally on a Raspberry Pi 3 B+ for the armv7hf part. All new tests pass, except
assert_vmvn_s8_vmvn
. I might be suffering from some form of #565 , please see my comment over there.