Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM Neon vmvn_*/vmvnq_* bitwise not intrinsics #770

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Add ARM Neon vmvn_*/vmvnq_* bitwise not intrinsics #770

merged 2 commits into from
Jul 15, 2019

Conversation

jmaibaum
Copy link
Contributor

@jmaibaum jmaibaum commented Jun 29, 2019

Hi,

I wanted to contribute to #148 by adding a family of ARM Neon intrinsics. I started with the vmvn_{s,u}* / vmvnq_{s,u}* family of intrinsics, which are all included in this PR, including tests.

I just found out that there are also the vmvn_p8 and vmvnq_p8 "poly" intrinsics which I did not yet implement. I would most likely want to add them as well before this PR should be merged. But, as this is my first contribution to the Rust standard libraries, I wanted to ask for comments/review first before continuing. So please let me know, if anything could/should be done different/better.

This has been tested locally on a Raspberry Pi 3 B+ for the armv7hf part. All new tests pass, except assert_vmvn_s8_vmvn. I might be suffering from some form of #565 , please see my comment over there.

@gnzlbg gnzlbg closed this Jul 9, 2019
@gnzlbg gnzlbg reopened this Jul 9, 2019
Copy link
Contributor

@gnzlbg gnzlbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Please ping me once CI is green - the wasm32 failure is spurious.

@jmaibaum
Copy link
Contributor Author

jmaibaum commented Jul 12, 2019

Added missing vmvn_p8/vmvnq_p8, which completes the vmvn* family of ARM Neon intrinsics.

Rebased on top of current master and thus force-pushed.

Local tests and codegen checks on RaspberryPi 3 B+ were all green now, crossing my fingers for CI.

@jmaibaum
Copy link
Contributor Author

@gnzlbg CI passed now, except for the following 3 Jobs:

  • mips-unknown-linux-gnu - build-only

  • wasm32-unknown-unknown (did not look into these two)

  • aarch64-android-linux - no assert_instr (Travis seems to have missed the output from the Android emulator here, errored after not receiving any output for 10mins)

@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 14, 2019

Could you please rebase this on top of master?

@jmaibaum
Copy link
Contributor Author

@gnzlbg Sure.

@gnzlbg gnzlbg merged commit 8cb42c9 into rust-lang:master Jul 15, 2019
@gnzlbg
Copy link
Contributor

gnzlbg commented Jul 15, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants