Don't include rustdoc members in rustdoc-frontend #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
+1, makes sense to me, I mentioned this oddity here already: https://rust-lang.zulipchat.com/#narrow/stream/393423-t-rustdoc.2Fmeetings/topic/meeting.202024-07-08/near/449956825
Manishearth
approved these changes
Sep 21, 2024
notriddle
approved these changes
Sep 21, 2024
GuillaumeGomez
approved these changes
Sep 21, 2024
camelid
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustdoc frontend was created so that rustdoc people who didn't work on the HTML output didn't need to block FCP's to that. However, they're still pinged when @rust-lang/rustdoc-frontend is pinged, because their still part of the github team.
CC @rust-lang/rustdoc, if you want pings for @rust-lang/rustdoc-frontend after this, you should add yourself (or speak up here if you think this is a bad idea).
zulip discussion