Rename GitHub token env var #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will likely require updating simpleinfra to handle the secret there. Would it be possible to read both env vars to make the transition easier? |
apiraino
force-pushed
the
rename-gh-token-env-var
branch
from
7d534d4
to
f709cb9
Compare
apiraino
force-pushed
the
rename-gh-token-env-var
branch
from
f709cb9
to
751379c
Compare
|
ok @ehuss I've added again the old env var when looking for a GH token but I'd keep the rest as it is to discourage using the old one :) should be ready for reaview again, I think. |
ehuss
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Looks good to me. I'll leave this to @Mark-Simulacrum to actually click the merge button in case there are problems or it needs to be reverted, but I don't expect there to be any issues.
|
Feel free to merge especially now that you have logs :) If those aren't enough let me know what else would help. Otherwise I'll try to get to this but it'll probably be next weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1789
r? @jackh726